From: Ryan Eatmon <reatmon@ti.com>
To: Praneeth Bajjuri <praneeth@ti.com>,
Denys Dmytriyenko <denys@konsulko.com>,
<meta-arago@lists.yoctoproject.org>
Subject: [meta-arago][master/kirkstone][PATCH] tisdk-*-image: Fix SYSTEMD_DEFAULT_TARGET assignment
Date: Thu, 25 Jan 2024 10:58:38 -0600 [thread overview]
Message-ID: <20240125165838.5539-1-reatmon@ti.com> (raw)
The use of the variable SYSTEMD_DEFAULT_TARGET is as a filename target.
But the extra whitespace in the string caused by the link breaks and
indents added spaces between the directory and the filename which
resulted in the following error:
run.set_systemd_default_target.23991: line 147: [: too many arguments
Signed-off-by: Ryan Eatmon <reatmon@ti.com>
---
meta-arago-distro/recipes-core/images/tisdk-default-image.bb | 4 +---
.../recipes-core/images/tisdk-thinlinux-image.bb | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
index 33ed0f57..7761ac34 100644
--- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
+++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
@@ -8,9 +8,7 @@ require arago-image.inc
ARAGO_DEFAULT_IMAGE_EXTRA_INSTALL ?= ""
# we're assuming some display manager is being installed with opengl
-SYSTEMD_DEFAULT_TARGET = " \
- ${@bb.utils.contains('DISTRO_FEATURES','opengl','graphical.target','multi-user.target',d)} \
-"
+SYSTEMD_DEFAULT_TARGET = "${@bb.utils.contains('DISTRO_FEATURES','opengl','graphical.target','multi-user.target',d)}"
IMAGE_INSTALL += "\
packagegroup-arago-base \
diff --git a/meta-arago-distro/recipes-core/images/tisdk-thinlinux-image.bb b/meta-arago-distro/recipes-core/images/tisdk-thinlinux-image.bb
index f266b14a..13e86902 100644
--- a/meta-arago-distro/recipes-core/images/tisdk-thinlinux-image.bb
+++ b/meta-arago-distro/recipes-core/images/tisdk-thinlinux-image.bb
@@ -9,9 +9,7 @@ require arago-image.inc
ARAGO_THIN_IMAGE_EXTRA_INSTALL ?= ""
# we're assuming some display manager is being installed with opengl
-SYSTEMD_DEFAULT_TARGET = " \
- ${@bb.utils.contains('DISTRO_FEATURES','opengl','graphical.target','multi-user.target',d)} \
-"
+SYSTEMD_DEFAULT_TARGET = "${@bb.utils.contains('DISTRO_FEATURES','opengl','graphical.target','multi-user.target',d)}"
IMAGE_INSTALL += "\
packagegroup-arago-base \
--
2.17.1
reply other threads:[~2024-01-25 16:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125165838.5539-1-reatmon@ti.com \
--to=reatmon@ti.com \
--cc=denys@konsulko.com \
--cc=meta-arago@lists.yoctoproject.org \
--cc=praneeth@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).