From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: patrick.wicki@subset.ch
Cc: meta-virtualization@lists.yoctoproject.org,
Patrick Wicki <patrick.wicki@siemens.com>
Subject: Re: [meta-virtualization][PATCH v2 1/2] podman: remove skopeo rdepends
Date: Mon, 13 May 2024 22:31:09 -0400 [thread overview]
Message-ID: <ZkLM7SjogJVi68Qx@gmail.com> (raw)
In-Reply-To: <20240506082806.292832-1-patrick.wicki@subset.ch>
v2 of the patches are on master-next
Bruce
In message: [meta-virtualization][PATCH v2 1/2] podman: remove skopeo rdepends
on 06/05/2024 Patrick Wicki via lists.yoctoproject.org wrote:
> From: Patrick Wicki <patrick.wicki@siemens.com>
>
> Podman does not require skopeo to run. They are both independent tools.
> In distros like Debian, Fedora and Arch they don't depend on it either.
> Skopeo also seems to be used in some of podman's tests, so it makes
> sense to keep it around for the ptest.
>
> We do require skopeo's libdevmapper dependency, so include that
> directly. And inherit container-host to make sure the container configs
> are present on the device.
>
> Signed-off-by: Patrick Wicki <patrick.wicki@siemens.com>
> ---
> recipes-containers/podman/podman_git.bb | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/recipes-containers/podman/podman_git.bb b/recipes-containers/podman/podman_git.bb
> index 32de3f0c..07c17449 100644
> --- a/recipes-containers/podman/podman_git.bb
> +++ b/recipes-containers/podman/podman_git.bb
> @@ -55,6 +55,7 @@ TOOLCHAIN = "gcc"
> export BUILDFLAGS="${GOBUILDFLAGS}"
>
> inherit go goarch
> +inherit container-host
> inherit systemd pkgconfig ptest
>
> do_configure[noexec] = "1"
> @@ -149,7 +150,7 @@ VIRTUAL-RUNTIME_base-utils-nsenter ?= "util-linux-nsenter"
> COMPATIBLE_HOST = "^(?!mips).*"
>
> RDEPENDS:${PN} += "\
> - conmon ${VIRTUAL-RUNTIME_container_runtime} iptables ${VIRTUAL-RUNTIME_container_networking} skopeo ${VIRTUAL-RUNTIME_base-utils-nsenter} \
> + conmon ${VIRTUAL-RUNTIME_container_runtime} iptables libdevmapper ${VIRTUAL-RUNTIME_container_networking} ${VIRTUAL-RUNTIME_base-utils-nsenter} \
> ${@bb.utils.contains('PACKAGECONFIG', 'rootless', 'fuse-overlayfs slirp4netns', '', d)} \
> "
> RRECOMMENDS:${PN} += "slirp4netns \
> @@ -172,5 +173,6 @@ RDEPENDS:${PN}-ptest += " \
> gnupg \
> jq \
> make \
> + skopeo \
> tar \
> "
> --
> 2.45.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8716): https://lists.yoctoproject.org/g/meta-virtualization/message/8716
> Mute This Topic: https://lists.yoctoproject.org/mt/105935939/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
prev parent reply other threads:[~2024-05-14 2:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 8:28 [meta-virtualization][PATCH v2 1/2] podman: remove skopeo rdepends patrick.wicki
2024-05-06 8:28 ` [meta-virtualization][PATCH v2 2/2] podman: require catatonit patrick.wicki
2024-05-14 2:31 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkLM7SjogJVi68Qx@gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=meta-virtualization@lists.yoctoproject.org \
--cc=patrick.wicki@siemens.com \
--cc=patrick.wicki@subset.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).