From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Marlon Rodriguez Garcia
<marlon.rodriguez-garcia@savoirfairelinux.com>,
bitbake-devel@lists.openembedded.org,
toaster@lists.yoctoproject.org
Subject: Re: [bitbake-devel] [PATCH] toaster: Added feat to import eventlogs files as builds in toaster
Date: Wed, 29 Nov 2023 11:38:13 +0000 [thread overview]
Message-ID: <b09c64c3bce3210b8265550c864f1df98bc13b35.camel@linuxfoundation.org> (raw)
In-Reply-To: <20231127204913.94683-1-marlon.rodriguez-garcia@savoirfairelinux.com>
Hi Marlon,
On Mon, 2023-11-27 at 15:49 -0500, Marlon Rodriguez Garcia wrote:
> New feature added to recreate command line builds that are made when toaster is off.
> The feature contains a new button on the base template to access a new template.
> A new model was added to register the information on the builds and generate access links
> A new form was added to include the option to load specific files
> This feature uses the value from the variable BB_DEFAULT_EVENTLOG to read the files created by bitbake
>
> Signed-off-by: Marlon Rodriguez Garcia <marlon.rodriguez-garcia@savoirfairelinux.com>
> ---
> lib/bb/ui/toasterui.py | 2 +-
> .../orm/migrations/0021_eventlogsimports.py | 22 ++
> lib/toaster/orm/models.py | 9 +
> lib/toaster/toastergui/forms.py | 13 ++
> lib/toaster/toastergui/templates/base.html | 3 +-
> .../templates/command_line_builds.html | 171 ++++++++++++++++
> lib/toaster/toastergui/urls.py | 1 +
> lib/toaster/toastergui/views.py | 188 +++++++++++++++++-
> 8 files changed, 405 insertions(+), 4 deletions(-)
> create mode 100644 lib/toaster/orm/migrations/0021_eventlogsimports.py
> create mode 100644 lib/toaster/toastergui/forms.py
> create mode 100644 lib/toaster/toastergui/templates/command_line_builds.html
Thanks, this is looking promising. I tested it and the main thing which
didn't feel so good from a UI perspective is that I'd click something
to import and I didn't get any feedback that it was happening. After a
while it would move me to the build page but there was no progress bar
or any other indication anything was happening. If I click a couple,
only the first is acted upon too.
Where the UI says "Import eventlog files from directory", I'd probably
change that to "Eventlogs from existing build directory:" but that is a
minor thing.
Also, on the landing page, would it make sense to put the "Import
commandline builds" as an extra button alongside the "Create your first
toaster project to run managed builds" and "Toaster is ready to capture
your commandline builds" on the landing page?
Cheers,
Richard
prev parent reply other threads:[~2023-11-29 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 20:49 [PATCH] toaster: Added feat to import eventlogs files as builds in toaster Marlon Rodriguez Garcia
2023-11-29 11:38 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b09c64c3bce3210b8265550c864f1df98bc13b35.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=marlon.rodriguez-garcia@savoirfairelinux.com \
--cc=toaster@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).