From: ross.burton@arm.com
To: yocto@lists.yoctoproject.org
Subject: [PATCH yocto-autobuilder-helper 2/3] scripts/abint: add argument parser
Date: Thu, 7 Mar 2024 16:42:44 +0000 [thread overview]
Message-ID: <20240307164245.783037-2-ross.burton@arm.com> (raw)
In-Reply-To: <20240307164245.783037-1-ross.burton@arm.com>
From: Ross Burton <ross.burton@arm.com>
Add an argument parser so that the use of the cache or verbose logging
can be enabled/disabled without having to edit the source code.
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
scripts/abint/abint.py | 45 ++++++++++++++++++++++--------------------
1 file changed, 24 insertions(+), 21 deletions(-)
diff --git a/scripts/abint/abint.py b/scripts/abint/abint.py
index d4fbed7e..1d358836 100755
--- a/scripts/abint/abint.py
+++ b/scripts/abint/abint.py
@@ -1,5 +1,6 @@
#! /usr/bin/env python3
+import argparse
import collections
import dataclasses
import logging
@@ -11,19 +12,6 @@ import arrow
import bugzilla
import requests
-MOCK = False
-# logging.basicConfig(level=logging.DEBUG)
-
-
-def save_pickle(name, data):
- with open(name, "wb") as f:
- pickle.dump(data, f, pickle.HIGHEST_PROTOCOL)
-
-
-def load_pickle(name):
- with open(name, "rb") as f:
- return pickle.load(f)
-
http = requests.Session()
@@ -104,15 +92,9 @@ def get_data():
except requests.exceptions.HTTPError as e:
logging.debug(f"Couldn't find build for {builder=} {build=}")
- save_pickle("bugs.data", bugs)
return bugs
-if MOCK:
-
- def get_data():
- return load_pickle("bugs.data")
-
def last_seen_report(data):
import jinja2
@@ -129,5 +111,26 @@ def last_seen_report(data):
f.write(template.render(bugs=data, start=start, now=arrow.now()))
-data = get_data()
-last_seen_report(data)
+CACHE_NAME = "bugs.data"
+
+if __name__ == "__main__":
+ parser = argparse.ArgumentParser()
+ parser.add_argument("--verbose", action="store_true", help="Enable verbose logging")
+ parser.add_argument("--cached", action="store_true", help="Use the local cached data instead of fetching")
+ args = parser.parse_args()
+
+ if args.verbose:
+ logging.basicConfig(level=logging.DEBUG)
+
+ if args.cached:
+ logging.debug(f"Loading cached data from {CACHE_NAME}")
+ with open(CACHE_NAME, "rb") as f:
+ data = pickle.load(f)
+ else:
+ data = get_data()
+ # Always save a cache because it's quick
+ logging.debug(f"Saving data to cache {CACHE_NAME}")
+ with open(CACHE_NAME, "wb") as f:
+ pickle.dump(data, f, pickle.HIGHEST_PROTOCOL)
+
+ last_seen_report(data)
--
2.34.1
next prev parent reply other threads:[~2024-03-07 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 16:42 [PATCH yocto-autobuilder-helper 1/3] scripts/abint: sort and organise imports ross.burton
2024-03-07 16:42 ` ross.burton [this message]
2024-03-07 16:42 ` [PATCH yocto-autobuilder-helper 3/3] scripts/abint: fix sorting on initial display ross.burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307164245.783037-2-ross.burton@arm.com \
--to=ross.burton@arm.com \
--cc=yocto@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).