From: Eric Wong <e@80x24.org>
To: mogilefs-client-public@bogomips.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH 2/3] more idiomatic comparisons with constants
Date: Mon, 14 Sep 2015 10:24:50 +0000 [thread overview]
Message-ID: <20150914102451.647-3-e@80x24.org> (raw)
In-Reply-To: <20150914102451.647-1-e@80x24.org>
These generates smaller bytecode than explicitly
comparing to a constant value.
---
lib/mogilefs/bigfile/filter.rb | 2 +-
lib/mogilefs/new_file/stream.rb | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/mogilefs/bigfile/filter.rb b/lib/mogilefs/bigfile/filter.rb
index e95a47e..d831312 100644
--- a/lib/mogilefs/bigfile/filter.rb
+++ b/lib/mogilefs/bigfile/filter.rb
@@ -33,7 +33,7 @@ class MogileFS::Bigfile::Filter
end
def write(buf)
- if nil == @zi
+ unless @zi
if @info[:compressed] &&
INFLATABLE_TYPES.include?(@info[:type]) &&
buf.bytesize >= 2 &&
diff --git a/lib/mogilefs/new_file/stream.rb b/lib/mogilefs/new_file/stream.rb
index a71be74..71ac591 100644
--- a/lib/mogilefs/new_file/stream.rb
+++ b/lib/mogilefs/new_file/stream.rb
@@ -42,7 +42,7 @@ class MogileFS::NewFile::Stream
def write(buf)
buf = String buf
- return 0 if 0 == buf.size
+ return 0 if buf.empty?
rv = @writer.write(buf)
@bytes_uploaded += rv
rv
--
EW
next prev parent reply other threads:[~2015-09-14 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 10:24 [PATCH 0/3] minor updates and cleanups Eric Wong
2015-09-14 10:24 ` [PATCH 1/3] admin: simplify utilization conversion Eric Wong
2015-09-14 10:24 ` Eric Wong [this message]
2015-09-14 10:24 ` [PATCH 3/3] bigfile/filter: only update MD5 if non-nil Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/mogilefs-client/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914102451.647-3-e@80x24.org \
--to=e@80x24.org \
--cc=mogilefs-client-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/mogilefs-client.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).