From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: mogilefs-client-public@bogomips.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 595A91F6D6; Mon, 14 Sep 2015 10:24:58 +0000 (UTC) From: Eric Wong To: mogilefs-client-public@bogomips.org Cc: Eric Wong Subject: [PATCH 2/3] more idiomatic comparisons with constants Date: Mon, 14 Sep 2015 10:24:50 +0000 Message-Id: <20150914102451.647-3-e@80x24.org> In-Reply-To: <20150914102451.647-1-e@80x24.org> References: <20150914102451.647-1-e@80x24.org> List-Id: These generates smaller bytecode than explicitly comparing to a constant value. --- lib/mogilefs/bigfile/filter.rb | 2 +- lib/mogilefs/new_file/stream.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/mogilefs/bigfile/filter.rb b/lib/mogilefs/bigfile/filter.rb index e95a47e..d831312 100644 --- a/lib/mogilefs/bigfile/filter.rb +++ b/lib/mogilefs/bigfile/filter.rb @@ -33,7 +33,7 @@ class MogileFS::Bigfile::Filter end def write(buf) - if nil == @zi + unless @zi if @info[:compressed] && INFLATABLE_TYPES.include?(@info[:type]) && buf.bytesize >= 2 && diff --git a/lib/mogilefs/new_file/stream.rb b/lib/mogilefs/new_file/stream.rb index a71be74..71ac591 100644 --- a/lib/mogilefs/new_file/stream.rb +++ b/lib/mogilefs/new_file/stream.rb @@ -42,7 +42,7 @@ class MogileFS::NewFile::Stream def write(buf) buf = String buf - return 0 if 0 == buf.size + return 0 if buf.empty? rv = @writer.write(buf) @bytes_uploaded += rv rv -- EW