Ruby mogilefs-client dev/users discussion/patches/bugs/help/...
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: mogilefs-client-public@bogomips.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH 3/3] bigfile/filter: only update MD5 if non-nil
Date: Mon, 14 Sep 2015 10:24:51 +0000	[thread overview]
Message-ID: <20150914102451.647-4-e@80x24.org> (raw)
In-Reply-To: <20150914102451.647-1-e@80x24.org>

It is possible to disable MD5 verification, so we cannot risk
updating a nil object.

Also, favor explicitly calling "update" instead of using "<<" which
YARV will attempt to optimize for Array/String receivers at the cost
of other objects (such as Digest::MD5)
---
 lib/mogilefs/bigfile/filter.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/mogilefs/bigfile/filter.rb b/lib/mogilefs/bigfile/filter.rb
index d831312..e3b6874 100644
--- a/lib/mogilefs/bigfile/filter.rb
+++ b/lib/mogilefs/bigfile/filter.rb
@@ -51,7 +51,7 @@ class MogileFS::Bigfile::Filter
     if @zi
       buf = @zi.inflate(buf)
     else
-      @md5 << buf
+      @md5.update(buf) if @md5
     end
     @io.write(buf)
   end
-- 
EW


      parent reply	other threads:[~2015-09-14 10:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14 10:24 [PATCH 0/3] minor updates and cleanups Eric Wong
2015-09-14 10:24 ` [PATCH 1/3] admin: simplify utilization conversion Eric Wong
2015-09-14 10:24 ` [PATCH 2/3] more idiomatic comparisons with constants Eric Wong
2015-09-14 10:24 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/mogilefs-client/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150914102451.647-4-e@80x24.org \
    --to=e@80x24.org \
    --cc=mogilefs-client-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/mogilefs-client.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).