From: Eric Wong <e@80x24.org>
To: mogilefs-client-public@bogomips.org
Subject: [PATCH 2/3] use opt_str_freeze to avoid allocations in a few places
Date: Thu, 29 Dec 2016 07:42:14 +0000 [thread overview]
Message-ID: <20161229074215.12425-3-e@80x24.org> (raw)
In-Reply-To: <20161229074215.12425-1-e@80x24.org>
None of these are too performance critical, but err on
the safe side and avoid allocations whenever possible.
---
lib/mogilefs/http_file.rb | 2 +-
lib/mogilefs/new_file/stream.rb | 8 ++++----
lib/mogilefs/new_file/writer.rb | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/mogilefs/http_file.rb b/lib/mogilefs/http_file.rb
index caf85ca..c7949a5 100644
--- a/lib/mogilefs/http_file.rb
+++ b/lib/mogilefs/http_file.rb
@@ -143,7 +143,7 @@ def nhp_put(devid, uri)
end
put = Net::HTTP::Put.new(uri.path)
- put["Content-Type"] = "application/octet-stream"
+ put["Content-Type"] = "application/octet-stream".freeze
if md5 = @opts[:content_md5]
if md5.respond_to?(:call)
md5 = md5.call.strip
diff --git a/lib/mogilefs/new_file/stream.rb b/lib/mogilefs/new_file/stream.rb
index 71ac591..195b121 100644
--- a/lib/mogilefs/new_file/stream.rb
+++ b/lib/mogilefs/new_file/stream.rb
@@ -66,7 +66,7 @@ def commit
def start_sock(sock, uri)
host_with_port = "#{uri.host}:#{uri.port}"
headers = "PUT #{uri.request_uri} HTTP/1.1\r\n" \
- "Host: #{host_with_port}\r\n" \
+ "Host: #{host_with_port}\r\n"
content_md5 = @opts[:content_md5]
if String === content_md5
@@ -75,16 +75,16 @@ def start_sock(sock, uri)
:trailer == content_md5 ||
MD5_TRAILER_NODES[host_with_port]
@md5 = Digest::MD5.new
- headers << "Trailer: Content-MD5\r\n"
+ headers << "Trailer: Content-MD5\r\n".freeze
end
if ! @md5 && clen = @opts[:content_length]
headers << "Content-Length: #{clen}\r\n"
else
- headers << "Transfer-Encoding: chunked\r\n"
+ headers << "Transfer-Encoding: chunked\r\n".freeze
end
- sock.write(headers << "\r\n")
+ sock.write(headers << "\r\n".freeze)
end
alias syswrite write
diff --git a/lib/mogilefs/new_file/writer.rb b/lib/mogilefs/new_file/writer.rb
index d58a4e6..e2f13fc 100644
--- a/lib/mogilefs/new_file/writer.rb
+++ b/lib/mogilefs/new_file/writer.rb
@@ -9,7 +9,7 @@ module MogileFS::NewFile::Writer
def puts(*args)
args.each do |obj|
write(obj)
- write("\n")
+ write("\n".freeze)
end
nil
end
--
EW
next prev parent reply other threads:[~2016-12-29 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 7:42 [PATCH 0/3] misc cleanups Eric Wong
2016-12-29 7:42 ` [PATCH 1/3] avoid pointless capture in regexp Eric Wong
2016-12-29 7:42 ` Eric Wong [this message]
2016-12-29 7:42 ` [PATCH 3/3] new_file/common: simplify empty class declarations Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/mogilefs-client/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161229074215.12425-3-e@80x24.org \
--to=e@80x24.org \
--cc=mogilefs-client-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/mogilefs-client.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).