* [PATCH] socket_common: expand IO#write garbage workaround to 2.0 and 2.1
@ 2017-02-03 22:58 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2017-02-03 22:58 UTC (permalink / raw)
To: mogilefs-client-public
On reading more carefully, it seems this change is from
r34847 which landed in Ruby 2.0. So we still need to support
Ruby 2.0 and 2.1 users.
---
lib/mogilefs/socket_common.rb | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/mogilefs/socket_common.rb b/lib/mogilefs/socket_common.rb
index 886c738..212f5da 100644
--- a/lib/mogilefs/socket_common.rb
+++ b/lib/mogilefs/socket_common.rb
@@ -58,9 +58,10 @@ def readpartial(size, buf = "", timeout = 5)
# Workaround for https://bugs.ruby-lang.org/issues/13085
# (excessive garbage from IO#write)
- # This looks like it will be fixed in Ruby 2.5 final.
+ # This regression was introduced in Ruby 2.0 (r34847)
+ # and looks like it will be fixed in Ruby 2.5 final.
if defined?(RUBY_ENGINE) && RUBY_ENGINE == 'ruby' &&
- RUBY_VERSION.to_f >= 2.2 && RUBY_VERSION.to_f <= 2.4
+ RUBY_VERSION.to_f >= 2.0 && RUBY_VERSION.to_f <= 2.4
def write(buf)
# Blocking TCP writes would error out long before one day,
# and MogileFS won't allow file creations which take over a day.
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-02-03 22:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-03 22:58 [PATCH] socket_common: expand IO#write garbage workaround to 2.0 and 2.1 Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/mogilefs-client.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).