Ruby mogilefs-client dev/users discussion/patches/bugs/help/...
 help / color / Atom feed
* [PATCH] socket_common: expand IO#write garbage workaround to 2.0 and 2.1
@ 2017-02-03 22:58 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2017-02-03 22:58 UTC (permalink / raw)
  To: mogilefs-client-public

On reading more carefully, it seems this change is from
r34847 which landed in Ruby 2.0.  So we still need to support
Ruby 2.0 and 2.1 users.
---
 lib/mogilefs/socket_common.rb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/mogilefs/socket_common.rb b/lib/mogilefs/socket_common.rb
index 886c738..212f5da 100644
--- a/lib/mogilefs/socket_common.rb
+++ b/lib/mogilefs/socket_common.rb
@@ -58,9 +58,10 @@ def readpartial(size, buf = "", timeout = 5)
 
   # Workaround for https://bugs.ruby-lang.org/issues/13085
   # (excessive garbage from IO#write)
-  # This looks like it will be fixed in Ruby 2.5 final.
+  # This regression was introduced in Ruby 2.0 (r34847)
+  # and looks like it will be fixed in Ruby 2.5 final.
   if defined?(RUBY_ENGINE) && RUBY_ENGINE == 'ruby' &&
-     RUBY_VERSION.to_f >= 2.2 && RUBY_VERSION.to_f <= 2.4
+     RUBY_VERSION.to_f >= 2.0 && RUBY_VERSION.to_f <= 2.4
     def write(buf)
       # Blocking TCP writes would error out long before one day,
       # and MogileFS won't allow file creations which take over a day.
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-03 22:58 [PATCH] socket_common: expand IO#write garbage workaround to 2.0 and 2.1 Eric Wong

Ruby mogilefs-client dev/users discussion/patches/bugs/help/...

Archives are clonable:
	git clone --mirror https://yhbt.net/mogilefs-client-public
	git clone --mirror http://ou63pmih66umazou.onion/mogilefs-client-public

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.file-systems.mogilefs.ruby
	nntp://ou63pmih66umazou.onion/inbox.comp.file-systems.mogilefs.ruby

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git