mirror of mongrel-development@rubyforge.org (inactive)
 help / color / mirror / Atom feed
From: Jos Backus <jos@catnook.com>
To: mongrel-development@rubyforge.org, puppet-dev@googlegroups.com
Subject: Re: [Mongrel-development] Mongrel doesn't set close-on-exec on its listen socket
Date: Mon, 18 Aug 2008 20:08:44 -0700	[thread overview]
Message-ID: <20080819030844.GA53303@lizzy.catnook.local> (raw)
In-Reply-To: <20080818215844.GA1441@yp-box.dyndns.org>


On Mon, Aug 18, 2008 at 02:59:21PM -0700, Eric Wong wrote:
> This probably works:
> 
> diff --git a/lib/mongrel.rb b/lib/mongrel.rb
> index 8b5dfe2..027bfdb 100644
> --- a/lib/mongrel.rb
> +++ b/lib/mongrel.rb
> @@ -91,6 +91,9 @@ module Mongrel
>        
>        tries = 0
>        @socket = TCPServer.new(host, port) 
> +      if defined?(Fcntl::FD_CLOEXEC)
> +        @socket.fcntl(Fcntl::F_SETFD, Fcntl::FD_CLOEXEC)
> +      end
>        
>        @classifier = URIClassifier.new
>        @host = host

Looks reasonable to me. Thanks, Eric. Can somebody commit, please?

-- 
Jos Backus
jos at catnook.com

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com
To unsubscribe from this group, send email to puppet-dev+unsubscribe@googlegroups.com
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

  reply	other threads:[~2008-08-19  3:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-22 16:31 Jos Backus
     [not found] ` <20080722163104.GA82787-/yjMewivvDbpLr52UxKYZsM6rOWSkUom@public.gmane.org>
2008-08-18 21:59   ` Eric Wong
2008-08-19  3:08     ` Jos Backus [this message]
     [not found]       ` <20080819030844.GA53303-/yjMewivvDbpLr52UxKYZsM6rOWSkUom@public.gmane.org>
2008-08-20  8:27         ` Eric Wong
     [not found]           ` <20080820082737.GA2403-G9TX8C5UF5wdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2008-11-04 20:41             ` Jos Backus
     [not found]               ` <20081104204159.GA48584-/yjMewivvDbpLr52UxKYZsM6rOWSkUom@public.gmane.org>
2008-11-08  2:15                 ` Eric Wong
replies disabled, historical list

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).