From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jos Backus Newsgroups: gmane.comp.sysutils.puppet.devel,gmane.comp.lang.ruby.mongrel.devel Subject: Re: [Mongrel-development] Mongrel doesn't set close-on-exec on its listen socket Date: Mon, 18 Aug 2008 20:08:44 -0700 Message-ID: <20080819030844.GA53303@lizzy.catnook.local> References: <20080722163104.GA82787@lizzy.catnook.local> <20080818215844.GA1441@yp-box.dyndns.org> Reply-To: puppet-dev@googlegroups.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1219115333 9451 80.91.229.12 (19 Aug 2008 03:08:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Aug 2008 03:08:53 +0000 (UTC) To: mongrel-development@rubyforge.org, puppet-dev@googlegroups.com Original-X-From: grbounce-vwjY7QUAAADwX8_IaRnYB_4akwqsXb0B=gcspd-puppet-dev=m.gmane.org@googlegroups.com Tue Aug 19 05:09:45 2008 Return-path: Envelope-to: gcspd-puppet-dev@m.gmane.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:received:x-sender:x-apparently-to :received:received:received-spf:authentication-results:received:date :from:to:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to:user-agent:sender:precedence:x-google-loop :mailing-list:list-id:list-post:list-help:list-unsubscribe :x-beenthere; bh=OHBU6Y57HLElx+p87SuiMKREN8txfhXEA2RoDR+TRac=; b=Yk+QnhnT+ICfh/VsNcEtYvRgTB7ZBtKAyF+WzGevox6lt2kIen9OdRb1QRJhJ7CvpN /MrUoOUVUo7YH9wEKQOXYgBpMGLuaWosB9MtmF3CstL/oI4epd0JrUm8PFHzfyAApHuy wY8BLjQH1nOojPqGteFfXF+37Jm5I6fFMzXKE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-sender:x-apparently-to:received-spf:authentication-results:date :from:to:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to:user-agent:sender:precedence:x-google-loop :mailing-list:list-id:list-post:list-help:list-unsubscribe :x-beenthere; b=OmuqHyuNoLSWVlRAdl0DMpY6tOKclvbvK4PkZfuru5nxz+m78V9Z4MedVDr3xPV+ha hhVFh/5bwrjVKdKLzU+RdsuYpGfffsBhf5bnLt8+3qEC3Vfvf6+/oRE2C5EWcvyOqEPs 5GzTxWuwnoBuF2D5CsANkd+3lMJbRCY9u5EtE= X-Sender: jos@catnook.com X-Apparently-To: puppet-dev@googlegroups.com Received-SPF: neutral (google.com: 209.204.188.132 is neither permitted nor denied by best guess record for domain of jos@catnook.com) client-ip=209.204.188.132; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.204.188.132 is neither permitted nor denied by best guess record for domain of jos@catnook.com) smtp.mail=jos@catnook.com In-Reply-To: <20080818215844.GA1441@yp-box.dyndns.org> User-Agent: Mutt/1.5.18 (2008-05-17) Original-Sender: puppet-dev@googlegroups.com Precedence: bulk X-Google-Loop: groups Mailing-List: list puppet-dev@googlegroups.com; contact puppet-dev+owner@googlegroups.com List-Id: List-Post: List-Help: List-Unsubscribe: , X-BeenThere: puppet-dev@googlegroups.com Xref: news.gmane.org gmane.comp.sysutils.puppet.devel:4532 gmane.comp.lang.ruby.mongrel.devel:64 Archived-At: Received: from mail-gx0-f57.google.com ([209.85.217.57]) by lo.gmane.org with esmtp (Exim 4.50) id 1KVHbJ-00088A-Je for gcspd-puppet-dev@m.gmane.org; Tue, 19 Aug 2008 05:09:41 +0200 Received: by gxk17 with SMTP id 17so27348397gxk.5 for ; Mon, 18 Aug 2008 20:08:41 -0700 (PDT) Received: by 10.214.148.5 with SMTP id v5mr374445qad.6.1219115315422; Mon, 18 Aug 2008 20:08:35 -0700 (PDT) Received: by 10.106.212.23 with SMTP id k23gr832prg.0; Mon, 18 Aug 2008 20:08:28 -0700 (PDT) Received: by 10.215.101.2 with SMTP id d2mr10059489qam.29.1219115307836; Mon, 18 Aug 2008 20:08:27 -0700 (PDT) Received: from lizzy.dyndns.org (209-204-188-132.dsl.static.sonic.net [209.204.188.132]) by mx.google.com with SMTP id 39si17130056yxd.2.2008.08.18.20.08.26; Mon, 18 Aug 2008 20:08:27 -0700 (PDT) Received: (qmail 53318 invoked by uid 1000); 19 Aug 2008 03:08:44 -0000 List-Post: On Mon, Aug 18, 2008 at 02:59:21PM -0700, Eric Wong wrote: > This probably works: > > diff --git a/lib/mongrel.rb b/lib/mongrel.rb > index 8b5dfe2..027bfdb 100644 > --- a/lib/mongrel.rb > +++ b/lib/mongrel.rb > @@ -91,6 +91,9 @@ module Mongrel > > tries = 0 > @socket = TCPServer.new(host, port) > + if defined?(Fcntl::FD_CLOEXEC) > + @socket.fcntl(Fcntl::F_SETFD, Fcntl::FD_CLOEXEC) > + end > > @classifier = URIClassifier.new > @host = host Looks reasonable to me. Thanks, Eric. Can somebody commit, please? -- Jos Backus jos at catnook.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com To unsubscribe from this group, send email to puppet-dev+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---