Re: Mongrel doesn't set close-on-exec on its listen socket

[Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org>]

Jos Backus <jos-ER9Rz4keOotBDgjK7y7TUQ@public.gmane.org> wrote:
> On Mon, Aug 18, 2008 at 02:59:21PM -0700, Eric Wong wrote:
> > This probably works:
> > 
> > diff --git a/lib/mongrel.rb b/lib/mongrel.rb
> > index 8b5dfe2..027bfdb 100644
> > --- a/lib/mongrel.rb
> > +++ b/lib/mongrel.rb
> > @@ -91,6 +91,9 @@ module Mongrel
> >        
> >        tries = 0
> >        @socket = TCPServer.new(host, port) 
> > +      if defined?(Fcntl::FD_CLOEXEC)
> > +        @socket.fcntl(Fcntl::F_SETFD, Fcntl::FD_CLOEXEC)
> > +      end
> >        
> >        @classifier = URIClassifier.new
> >        @host = host
> 
> Looks reasonable to me. Thanks, Eric. Can somebody commit, please?

I've just committed it, r1036 to trunk.  Thanks for the report!

-- 
Eric Wong