mirror of mongrel-development@rubyforge.org (inactive)
 help / color / mirror / Atom feed
From: Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org>
To: mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
Subject: Re: Mongrel doesn't set close-on-exec on its	listen socket
Date: Fri, 7 Nov 2008 18:15:35 -0800	[thread overview]
Message-ID: <20081108021534.GA27211@yp-box.dyndns.org> (raw)
In-Reply-To: <20081104204159.GA48584-/yjMewivvDbpLr52UxKYZsM6rOWSkUom@public.gmane.org>

Jos Backus <jos-ER9Rz4keOotBDgjK7y7TUQ@public.gmane.org> wrote:
> On Wed, Aug 20, 2008 at 01:27:37AM -0700, Eric Wong wrote:
> > Jos Backus <jos-ER9Rz4keOotBDgjK7y7TUQ@public.gmane.org> wrote:
> > > On Mon, Aug 18, 2008 at 02:59:21PM -0700, Eric Wong wrote:
> > > > This probably works:
> > > 
> > > Looks reasonable to me. Thanks, Eric. Can somebody commit, please?
> > 
> > I've just committed it, r1036 to trunk.  Thanks for the report!
> 
> Thanks Eric. The patch is probably incomplete, as I just noticed a problem:
> 
> /usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel.rb:94:in
> `initialize': uninitialized constant Mongrel::HttpServer::Fcntl (NameError)
> 
> That code doesn't have the defined? test. But even if it did, it wouldn't work
> as `fcntl' hadn't been require'd so the Fcntl::FD_CLOEXEC constant couldn't be
> available until it was (if it was available).
> 
> So the right thing to do is to also apply this patch which explicitly
> require's `fcntl':

Applied, thanks!

-- 
Eric Wong

      parent reply	other threads:[~2008-11-08  3:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-22 16:31 Jos Backus
     [not found] ` <20080722163104.GA82787-/yjMewivvDbpLr52UxKYZsM6rOWSkUom@public.gmane.org>
2008-08-18 21:59   ` Eric Wong
2008-08-19  3:08     ` [Mongrel-development] " Jos Backus
     [not found]       ` <20080819030844.GA53303-/yjMewivvDbpLr52UxKYZsM6rOWSkUom@public.gmane.org>
2008-08-20  8:27         ` Eric Wong
     [not found]           ` <20080820082737.GA2403-G9TX8C5UF5wdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2008-11-04 20:41             ` Jos Backus
     [not found]               ` <20081104204159.GA48584-/yjMewivvDbpLr52UxKYZsM6rOWSkUom@public.gmane.org>
2008-11-08  2:15                 ` Eric Wong [this message]
replies disabled, historical list

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).