From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eric Wong Newsgroups: gmane.comp.lang.ruby.mongrel.devel Subject: Re: Mongrel doesn't set close-on-exec on its listen socket Date: Fri, 7 Nov 2008 18:15:35 -0800 Message-ID: <20081108021534.GA27211@yp-box.dyndns.org> References: <20080722163104.GA82787@lizzy.catnook.local> <20080818215844.GA1441@yp-box.dyndns.org> <20080819030844.GA53303@lizzy.catnook.local> <20080820082737.GA2403@yp-box.dyndns.org> <20081104204159.GA48584@lizzy.catnook.local> Reply-To: mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1226114314 3764 80.91.229.12 (8 Nov 2008 03:18:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Nov 2008 03:18:34 +0000 (UTC) To: mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Original-X-From: mongrel-development-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Sat Nov 08 04:19:37 2008 Return-path: Envelope-to: gclrmd-mongrel-development@m.gmane.org X-Greylist: delayed 1943 seconds by postgrey-1.31 at rubycentral.org; Fri, 07 Nov 2008 21:48:04 EST Content-Disposition: inline In-Reply-To: <20081104204159.GA48584-/yjMewivvDbpLr52UxKYZsM6rOWSkUom@public.gmane.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-BeenThere: mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: mongrel-development-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Errors-To: mongrel-development-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Xref: news.gmane.org gmane.comp.lang.ruby.mongrel.devel:67 Archived-At: Received: from rubyforge.org ([205.234.109.19]) by lo.gmane.org with esmtp (Exim 4.50) id 1KyeMK-0008UI-9m for gclrmd-mongrel-development@m.gmane.org; Sat, 08 Nov 2008 04:19:36 +0100 Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id A2E3918582B4; Fri, 7 Nov 2008 22:18:24 -0500 (EST) Received: from hand.yhbt.net (hand.yhbt.net [66.150.188.102]) by rubyforge.org (Postfix) with ESMTP id 193DA18581B8 for ; Fri, 7 Nov 2008 21:48:03 -0500 (EST) Received: from localhost.localdomain (localhost [127.0.0.1]) by hand.yhbt.net (Postfix) with ESMTP id 30B662DC01A; Sat, 8 Nov 2008 02:15:36 +0000 (UTC) List-Post: Jos Backus wrote: > On Wed, Aug 20, 2008 at 01:27:37AM -0700, Eric Wong wrote: > > Jos Backus wrote: > > > On Mon, Aug 18, 2008 at 02:59:21PM -0700, Eric Wong wrote: > > > > This probably works: > > > > > > Looks reasonable to me. Thanks, Eric. Can somebody commit, please? > > > > I've just committed it, r1036 to trunk. Thanks for the report! > > Thanks Eric. The patch is probably incomplete, as I just noticed a problem: > > /usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel.rb:94:in > `initialize': uninitialized constant Mongrel::HttpServer::Fcntl (NameError) > > That code doesn't have the defined? test. But even if it did, it wouldn't work > as `fcntl' hadn't been require'd so the Fcntl::FD_CLOEXEC constant couldn't be > available until it was (if it was available). > > So the right thing to do is to also apply this patch which explicitly > require's `fcntl': Applied, thanks! -- Eric Wong