Existing failures on stable 1.2

Existing failures on stable 1.2

[Luis Lavena]

Hello Guys,

I'm still getting these two:

  1) Failure:
test_horrible_queries(HttpParserTest)
    [./test/unit/test_http_parser.rb:105:in `test_horrible_queries'
     ./test/unit/test_http_parser.rb:103:in `times'
     ./test/unit/test_http_parser.rb:103:in `test_horrible_queries']:
<Mongrel::HttpParserError> exception expected but none was thrown.

  2) Error:
test_parse_strange_headers(HttpParserTest):
Mongrel::HttpParserError: Invalid HTTP format, parsing fails.
    ./test/unit/test_http_parser.rb:49:in `execute'
    ./test/unit/test_http_parser.rb:49:in `test_parse_strange_headers'

59 tests, 458 assertions, 1 failures, 1 errors

I want to confirm these are real (and not just me) and if someone else
is working on those, or should I tackle them.

Thanks in advance and have a nice weekend,
-- 
Luis Lavena
Multimedia systems
-
Human beings, who are almost unique in having the ability to learn from
the experience of others, are also remarkable for their apparent
disinclination to do so.
Douglas Adams

Re: Existing failures on stable 1.2

[Evan Weaver]

These are real-ish. We can fix the first one by reverting to Ragel 5.
We can just remove the second one and document headers with linebreaks
as being not supported.

Evan

On Sun, Apr 20, 2008 at 2:08 PM, Luis Lavena <luislavena-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hello Guys,
>
>  I'm still getting these two:
>
>   1) Failure:
>  test_horrible_queries(HttpParserTest)
>     [./test/unit/test_http_parser.rb:105:in `test_horrible_queries'
>      ./test/unit/test_http_parser.rb:103:in `times'
>      ./test/unit/test_http_parser.rb:103:in `test_horrible_queries']:
>  <Mongrel::HttpParserError> exception expected but none was thrown.
>
>   2) Error:
>  test_parse_strange_headers(HttpParserTest):
>  Mongrel::HttpParserError: Invalid HTTP format, parsing fails.
>     ./test/unit/test_http_parser.rb:49:in `execute'
>     ./test/unit/test_http_parser.rb:49:in `test_parse_strange_headers'
>
>  59 tests, 458 assertions, 1 failures, 1 errors
>
>  I want to confirm these are real (and not just me) and if someone else
>  is working on those, or should I tackle them.
>
>  Thanks in advance and have a nice weekend,
>  --
>  Luis Lavena
>  Multimedia systems
>  -
>  Human beings, who are almost unique in having the ability to learn from
>  the experience of others, are also remarkable for their apparent
>  disinclination to do so.
>  Douglas Adams
>  _______________________________________________
>  Mongrel-development mailing list
>  Mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
>  http://rubyforge.org/mailman/listinfo/mongrel-development
>



-- 
Evan Weaver
Cloudburst, LLC

Re: Existing failures on stable 1.2

[Luis Lavena]

On Sun, Apr 20, 2008 at 3:44 PM, Evan Weaver <evan-72XWLPH10WVXUHR/Jj/Uug@public.gmane.org> wrote:
> These are real-ish. We can fix the first one by reverting to Ragel 5.
>  We can just remove the second one and document headers with linebreaks
>  as being not supported.
>

I'm not against any of these two options. But I'll love to hear back
from the submitters of these patches and how they could endorse/fix
these issues without taking them out.

>  Evan
>

Regards,
-- 
Luis Lavena
Multimedia systems
-
Human beings, who are almost unique in having the ability to learn from
the experience of others, are also remarkable for their apparent
disinclination to do so.
Douglas Adams

Re: Existing failures on stable 1.2

[ry dahl]

 I was looking into that but had problems. The linebreak problem has
been there since 1.0.1

On Sun, Apr 20, 2008 at 8:44 PM, Evan Weaver <evan-72XWLPH10WVXUHR/Jj/Uug@public.gmane.org> wrote:
> These are real-ish. We can fix the first one by reverting to Ragel 5.
>  We can just remove the second one and document headers with linebreaks
>  as being not supported.
>
>  Evan
>
>
>
>  On Sun, Apr 20, 2008 at 2:08 PM, Luis Lavena <luislavena-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>  > Hello Guys,
>  >
>  >  I'm still getting these two:
>  >
>  >   1) Failure:
>  >  test_horrible_queries(HttpParserTest)
>  >     [./test/unit/test_http_parser.rb:105:in `test_horrible_queries'
>  >      ./test/unit/test_http_parser.rb:103:in `times'
>  >      ./test/unit/test_http_parser.rb:103:in `test_horrible_queries']:
>  >  <Mongrel::HttpParserError> exception expected but none was thrown.
>  >
>  >   2) Error:
>  >  test_parse_strange_headers(HttpParserTest):
>  >  Mongrel::HttpParserError: Invalid HTTP format, parsing fails.
>  >     ./test/unit/test_http_parser.rb:49:in `execute'
>  >     ./test/unit/test_http_parser.rb:49:in `test_parse_strange_headers'
>  >
>  >  59 tests, 458 assertions, 1 failures, 1 errors
>  >
>  >  I want to confirm these are real (and not just me) and if someone else
>  >  is working on those, or should I tackle them.
>  >
>  >  Thanks in advance and have a nice weekend,
>  >  --
>  >  Luis Lavena
>  >  Multimedia systems
>  >  -
>  >  Human beings, who are almost unique in having the ability to learn from
>  >  the experience of others, are also remarkable for their apparent
>  >  disinclination to do so.
>  >  Douglas Adams
>  >  _______________________________________________
>  >  Mongrel-development mailing list
>  >  Mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
>  >  http://rubyforge.org/mailman/listinfo/mongrel-development
>  >
>
>
>
>  --
>  Evan Weaver
>  Cloudburst, LLC
>
>
> _______________________________________________
>  Mongrel-development mailing list
>  Mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
>  http://rubyforge.org/mailman/listinfo/mongrel-development
>

Re: Existing failures on stable 1.2

[Luis Lavena]

On Sun, Apr 20, 2008 at 3:58 PM, ry dahl <ry-Xek56AhD01PHviPkdFu9cA@public.gmane.org> wrote:
>  I was looking into that but had problems. The linebreak problem has
>  been there since 1.0.1
>

Hmn, ran the tests for 1.0.1 at that time before release the binary
win32 gem and didn't see that failure...

But my brain start playing tricks lately, so cannot be 100% certain.
And seems I didn't yelled at the mailing list so maybe there was no
failure before ragel 5 on the code.

-- 
Luis Lavena
Multimedia systems
-
Human beings, who are almost unique in having the ability to learn from
the experience of others, are also remarkable for their apparent
disinclination to do so.
Douglas Adams

Re: Existing failures on stable 1.2

[ry dahl]

it's been commented out since at least 0.3.14. linebreaks in header
values is pretty debatable - does this actually happen?

On Sun, Apr 20, 2008 at 9:06 PM, Luis Lavena <luislavena-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Sun, Apr 20, 2008 at 3:58 PM, ry dahl <ry-Xek56AhD01PHviPkdFu9cA@public.gmane.org> wrote:
>  >  I was looking into that but had problems. The linebreak problem has
>  >  been there since 1.0.1
>  >
>
>  Hmn, ran the tests for 1.0.1 at that time before release the binary
>  win32 gem and didn't see that failure...
>
>  But my brain start playing tricks lately, so cannot be 100% certain.
>  And seems I didn't yelled at the mailing list so maybe there was no
>  failure before ragel 5 on the code.
>
>  --
>
>
> Luis Lavena
>  Multimedia systems
>  -
>  Human beings, who are almost unique in having the ability to learn from
>  the experience of others, are also remarkable for their apparent
>  disinclination to do so.
>  Douglas Adams
>  _______________________________________________
>  Mongrel-development mailing list
>  Mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
>  http://rubyforge.org/mailman/listinfo/mongrel-development
>

Re: Existing failures on stable 1.2

[Evan Weaver]

Nobody has ask for support that I know of.

Evan

On Sun, Apr 20, 2008 at 3:13 PM, ry dahl <ry-Xek56AhD01PHviPkdFu9cA@public.gmane.org> wrote:
> it's been commented out since at least 0.3.14. linebreaks in header
>  values is pretty debatable - does this actually happen?
>
>
>
>  On Sun, Apr 20, 2008 at 9:06 PM, Luis Lavena <luislavena-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>  > On Sun, Apr 20, 2008 at 3:58 PM, ry dahl <ry-Xek56AhD01PHviPkdFu9cA@public.gmane.org> wrote:
>  >  >  I was looking into that but had problems. The linebreak problem has
>  >  >  been there since 1.0.1
>  >  >
>  >
>  >  Hmn, ran the tests for 1.0.1 at that time before release the binary
>  >  win32 gem and didn't see that failure...
>  >
>  >  But my brain start playing tricks lately, so cannot be 100% certain.
>  >  And seems I didn't yelled at the mailing list so maybe there was no
>  >  failure before ragel 5 on the code.
>  >
>  >  --
>  >
>  >
>  > Luis Lavena
>  >  Multimedia systems
>  >  -
>  >  Human beings, who are almost unique in having the ability to learn from
>  >  the experience of others, are also remarkable for their apparent
>  >  disinclination to do so.
>  >  Douglas Adams
>  >  _______________________________________________
>  >  Mongrel-development mailing list
>  >  Mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
>  >  http://rubyforge.org/mailman/listinfo/mongrel-development
>  >
>  _______________________________________________
>  Mongrel-development mailing list
>  Mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
>  http://rubyforge.org/mailman/listinfo/mongrel-development
>



-- 
Evan Weaver
Cloudburst, LLC

Re: Existing failures on stable 1.2

[Eric Wong]

Pen sends SSL certs with them.  It actually shouldn't be too difficult
to support, but I'm very strapped for time these days.

ry dahl <ry-Xek56AhD01PHviPkdFu9cA@public.gmane.org> wrote:
> it's been commented out since at least 0.3.14. linebreaks in header
> values is pretty debatable - does this actually happen?
> 
> On Sun, Apr 20, 2008 at 9:06 PM, Luis Lavena <luislavena-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > On Sun, Apr 20, 2008 at 3:58 PM, ry dahl <ry-Xek56AhD01PHviPkdFu9cA@public.gmane.org> wrote:
> >  >  I was looking into that but had problems. The linebreak problem has
> >  >  been there since 1.0.1
> >  >
> >
> >  Hmn, ran the tests for 1.0.1 at that time before release the binary
> >  win32 gem and didn't see that failure...
> >
> >  But my brain start playing tricks lately, so cannot be 100% certain.
> >  And seems I didn't yelled at the mailing list so maybe there was no
> >  failure before ragel 5 on the code.

Re: Existing failures on stable 1.2

[Zed A. Shaw]

On Mon, 21 Apr 2008 10:38:42 -0700
Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org> wrote:

> Pen sends SSL certs with them.  It actually shouldn't be too difficult
> to support, but I'm very strapped for time these days.

And Pen is the only thing I've found that (ab)uses headers like this.
Most of the usage out there didn't need it so I didn't bother adding it.

Incidentally, http://www.and.org/and-httpd/ has an insane number of
tests for nearly every http thing you could think of testing.  I was
originally going to base a test suite on his stuff, but never got
around to it or found I needed it.

-- 
Zed A. Shaw
- Hate: http://savingtheinternetwithhate.com/
- Good: http://www.zedshaw.com/
- Evil: http://yearofevil.com/

Re: Existing failures on stable 1.2

[Luis Lavena]

On Mon, Apr 21, 2008 at 9:16 PM, Zed A. Shaw <zedshaw-dd7LMGGEL7NBDgjK7y7TUQ@public.gmane.org> wrote:
> On Mon, 21 Apr 2008 10:38:42 -0700
>  Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org> wrote:
>
>  > Pen sends SSL certs with them.  It actually shouldn't be too difficult
>  > to support, but I'm very strapped for time these days.
>
>  And Pen is the only thing I've found that (ab)uses headers like this.
>  Most of the usage out there didn't need it so I didn't bother adding it.
>
>  Incidentally, http://www.and.org/and-httpd/ has an insane number of
>  tests for nearly every http thing you could think of testing.  I was
>  originally going to base a test suite on his stuff, but never got
>  around to it or found I needed it.
>

So mighty Zed, what we should do? :-D

I've committed several changes to fix issues with mongrel_service for
next release, but want to get rid all the failures on both platforms
I'm supporting right now: i386-mswin32 and i386-mingw32 (VC6 and GCC
builds of Ruby).

So looking forward for suggestions before I pick up my axe (blame) and
get rid of those without asking :-D

-- 
Luis Lavena
Multimedia systems
-
Human beings, who are almost unique in having the ability to learn from
the experience of others, are also remarkable for their apparent
disinclination to do so.
Douglas Adams