From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Luis Lavena" Newsgroups: gmane.comp.lang.ruby.mongrel.devel Subject: Re: Mongrel and Windows: I was so dumb Date: Mon, 31 Mar 2008 01:25:34 -0300 Message-ID: <71166b3b0803302125m1db26236m25ba80c317fb0c3b@mail.gmail.com> References: <71166b3b0803302057k7ade0b07r71cf8929c4fe1bcf@mail.gmail.com> Reply-To: mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1206937546 16663 80.91.229.12 (31 Mar 2008 04:25:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 31 Mar 2008 04:25:46 +0000 (UTC) To: mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Original-X-From: mongrel-development-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Mon Mar 31 06:26:16 2008 Return-path: Envelope-to: gclrmd-mongrel-development@m.gmane.org In-Reply-To: Content-Disposition: inline X-BeenThere: mongrel-development-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: mongrel-development-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Errors-To: mongrel-development-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Xref: news.gmane.org gmane.comp.lang.ruby.mongrel.devel:28 Archived-At: Received: from rubyforge.org ([205.234.109.19]) by lo.gmane.org with esmtp (Exim 4.50) id 1JgBb6-0001Yd-4J for gclrmd-mongrel-development@m.gmane.org; Mon, 31 Mar 2008 06:26:16 +0200 Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 628091858688; Mon, 31 Mar 2008 00:25:36 -0400 (EDT) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.182]) by rubyforge.org (Postfix) with ESMTP id 0B1931858667 for ; Mon, 31 Mar 2008 00:25:34 -0400 (EDT) Received: by wa-out-1112.google.com with SMTP id l24so1755788waf.17 for ; Sun, 30 Mar 2008 21:25:35 -0700 (PDT) Received: by 10.114.144.1 with SMTP id r1mr9126738wad.135.1206937535025; Sun, 30 Mar 2008 21:25:35 -0700 (PDT) Received: by 10.114.151.14 with HTTP; Sun, 30 Mar 2008 21:25:34 -0700 (PDT) List-Post: On Mon, Mar 31, 2008 at 1:04 AM, Evan Weaver wrote: > Wow, that is bizarre. > > The platform checks are fine. Do they belong in Mongrel, or do they > belong in the build chain? > Specific platform usage inside mongrel: - To writer or not the pid file: http://mongrel.rubyforge.org/browser/trunk/lib/mongrel/configurator.rb#L83 (which is pointless, it should generate the pid file on every platform, even Windows). - Allow or not daemonize: http://mongrel.rubyforge.org/browser/trunk/lib/mongrel/configurator.rb#L189 Which is fair, it should remain there - Setup signals: http://mongrel.rubyforge.org/browser/trunk/lib/mongrel/configurator.rb#L364 Which is also good. Other places: http://mongrel.rubyforge.org/browser/trunk/bin/mongrel_rails#L139 the usage of restart on Windows, seems logical, since there are no signals to handle it. Oh, a good catch: http://mongrel.rubyforge.org/browser/trunk/bin/mongrel_rails#L85 Mongrel should validate pre-existing pids always, not only in daemonize mode. Thoughts? To use or not fastthread and cgi eof fix. http://mongrel.rubyforge.org/browser/trunk/lib/mongrel.rb#L13 Of course, a few more check on the new Logger (buffered logger) and cgi_multipart eof subproject. Fastthread, GemPlugin and even mongrel_service (yeah, I plain suck at planing on the long run). -- Luis Lavena Multimedia systems - Human beings, who are almost unique in having the ability to learn from the experience of others, are also remarkable for their apparent disinclination to do so. Douglas Adams