summary refs log tree commit
diff options
context:
space:
mode:
authorJeremy Evans <code@jeremyevans.net>2022-03-17 20:16:46 -0700
committerJeremy Evans <code@jeremyevans.net>2022-04-04 17:12:14 -0700
commit140db09640a4dfa45a9681f64b93fbbb233ae89b (patch)
treea9854ff2ad25cdd0e67171a1084eefa0a4ad8175
parentb87d1828bd90b24eb0fa4a99abf580d9ddde4a0e (diff)
downloadrack-140db09640a4dfa45a9681f64b93fbbb233ae89b.tar.gz
Inline FORWARDED_PAIR_REGEX
Only used in one place and no interpolation, there is no reason to
use a constant in this case.
-rw-r--r--lib/rack/utils.rb4
1 files changed, 1 insertions, 3 deletions
diff --git a/lib/rack/utils.rb b/lib/rack/utils.rb
index 8706a894..cd252901 100644
--- a/lib/rack/utils.rb
+++ b/lib/rack/utils.rb
@@ -140,15 +140,13 @@ module Rack
       end
     end
 
-    FORWARDED_PAIR_REGEX = /\A\s*(by|for|host|proto)\s*=\s*"?([^"]+)"?\s*\Z/i
-
     def forwarded_values(forwarded_header)
       return nil unless forwarded_header
       forwarded_header = forwarded_header.to_s.gsub("\n", ";")
 
       forwarded_header.split(/\s*;\s*/).each_with_object({}) do |field, values|
         field.split(/\s*,\s*/).each do |pair|
-          return nil unless pair =~ FORWARDED_PAIR_REGEX
+          return nil unless pair =~ /\A\s*(by|for|host|proto)\s*=\s*"?([^"]+)"?\s*\Z/i
           (values[$1.downcase.to_sym] ||= []) << $2
         end
       end