From daef95d81b1c3b4dfe3e955d5f34d1be569d86b0 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 12 May 2016 02:06:36 +0000 Subject: lint: clarify "rack.hijack" case-sensitivity in response Based on my inspection of the webrick handler, it was ambiguous as to whether "rack.hijack" is supposed to be case-sensitive or not. Thankfully James cleared it up: http://mid.gmane.org/CABGa_T8ihnKWwguObGCQqF-qBA+_v1YwM1-2tv3y5ShbWo4scw@mail.gmail.com Note: I manually reapplied the SPEC change in commit 72185735ad0c3aea4e37ab66b0c370e42180df39 ("Fixed link and rack.session's indentation in SPEC") after regenerating it from lint.rb --- SPEC | 3 ++- lib/rack/lint.rb | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/SPEC b/SPEC index 7e3af40a..a5999b39 100644 --- a/SPEC +++ b/SPEC @@ -200,7 +200,8 @@ have been sent. In order to do this, an application may set the special header rack.hijack to an object that responds to call accepting an argument that conforms to the rack.hijack_io -protocol. +protocol. Unlike normal response headers, rack.hijack +is case-sensitive. After the headers have been sent, and this hijack callback has been called, the application is now responsible for the remaining lifecycle of the IO. The application is also responsible for maintaining HTTP diff --git a/lib/rack/lint.rb b/lib/rack/lint.rb index 54d37822..6eb24764 100644 --- a/lib/rack/lint.rb +++ b/lib/rack/lint.rb @@ -573,7 +573,8 @@ module Rack ## In order to do this, an application may set the special header ## rack.hijack to an object that responds to call ## accepting an argument that conforms to the rack.hijack_io - ## protocol. + ## protocol. Unlike normal response headers, rack.hijack + ## is case-sensitive. ## ## After the headers have been sent, and this hijack callback has been ## called, the application is now responsible for the remaining lifecycle -- cgit v1.2.3-24-ge0c7