From dc53a8c26dc55d21240233b3d83d36efdef6e924 Mon Sep 17 00:00:00 2001 From: schneems Date: Wed, 1 Oct 2014 18:09:37 -0500 Subject: Less allocated objects on each request How many? Using `memory_profiler` and a Rails app (codetriage.com), master uses: ``` rack/lib x 7318 ``` After this patch, the app uses: ``` rack/lib x 4598 ``` Or `(7318 - 4598) / 7318.0 * 100 # => 37.16` % fewer objects __PER REQUEST__. To do this, I extracted really commonly used strings into top level Rack constants. It makes for a bit of a big diff, but I believe the changes are worth it. Running benchmark/ips against the same app, I'm seeing a performance host of `2~4%` across the entire app response. This doesn't just make Rack faster, it will make your app faster. While we could certainly go overboard and pre-define ALL strings as constants, that would be pretty gnarly to work with. This patch goes after the largest of the low hanging fruit. --- lib/rack/cascade.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/rack/cascade.rb') diff --git a/lib/rack/cascade.rb b/lib/rack/cascade.rb index c2891e5f..6b8f415a 100644 --- a/lib/rack/cascade.rb +++ b/lib/rack/cascade.rb @@ -4,7 +4,7 @@ module Rack # status codes). class Cascade - NotFound = [404, {"Content-Type" => "text/plain"}, []] + NotFound = [404, {CONTENT_TYPE => "text/plain"}, []] attr_reader :apps -- cgit v1.2.3-24-ge0c7