Rainbows! Rack HTTP server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org>
To: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
Subject: [PATCH 2/1] fix Ruby 1.8 detection for (possible) green thread fix
Date: Tue, 22 Dec 2009 12:50:08 -0800	[thread overview]
Message-ID: <20091222205008.GA11119@dcvr.yhbt.net> (raw)
In-Reply-To: <20091222005421.GA23044-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>

Thanks to Ben Sandofsky for the extra set of eyes

 The patch yesterday was bogus and needs this, also pushed out to
 rainbows.git of course.

 lib/rainbows/base.rb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/rainbows/base.rb b/lib/rainbows/base.rb
index 4a4d076..20c7681 100644
--- a/lib/rainbows/base.rb
+++ b/lib/rainbows/base.rb
@@ -15,7 +15,7 @@ module Rainbows
       G.tmp = worker.tmp
       # avoid spurious wakeups and blocking-accept() with 1.8 green threads
-      if RUBY_VERSION.to_f < 1.8
+      if RUBY_VERSION.to_f < 1.9
         require "io/nonblock"
         LISTENERS.each { |l| l.nonblock = true }
Eric Wong
Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
Do not quote signatures (like this one) or top post when replying

  parent reply	other threads:[~2009-12-22 20:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-21 22:10 possible ThreadSpawn + Ruby 1.8 issues Eric Wong
     [not found] ` <20091221221002.GA12277-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2009-12-22  0:54   ` [PATCH] possible MRI 1.8 thread fix to avoid blocking accept() Eric Wong
     [not found]     ` <20091222005421.GA23044-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2009-12-22 20:50       ` Eric Wong [this message]
     [not found]         ` <20091222205008.GA11119-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2009-12-22 21:34           ` [PATCH 3/1] base: fix constant resolution under 1.8 for 1.8 bugfix Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/rainbows/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091222205008.GA11119@dcvr.yhbt.net \
    --to=normalperson-rmlxzr9ms24@public.gmane.org \
    --cc=rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).