From: Eric Wong <normalperson@yhbt.net>
To: ruby-talk@ruby-lang.org (ruby-talk ML)
,mongrel-unicorn@rubyforge.org, rainbows-talk@rubyforge.org
Subject: [ANN] unicorn 0.96.1 - leak fix for Rainbows!/Zbatery
Date: Sat, 13 Feb 2010 19:34:10 +0900 [thread overview]
Message-ID: <20100213103409.GA7833@dcvr.yhbt.net> (raw)
First off, this memory leak doesn't affect Unicorn itself at all
(but it doesn't hurt, either).
Unicorn itself always allocates the HttpParser once and always reuses it
in every sequential request.
This leak only affects applications that repeatedly allocate a new HTTP
parser. Thus this bug affects _all_ deployments of Rainbows! and
Zbatery. These servers allocate a new parser for every client
connection to serve clients concurrently, but due to a bug in Unicorn,
never allows the Ruby GC to properly free the memory allocated.
Here's what happened:
I misread the Data_Make_Struct()/Data_Wrap_Struct()
documentation and ended up passing NULL as the "free" argument
instead of -1, causing the memory to never be freed.
From README.EXT in the MRI source which I misread:
> The free argument is the function to free the pointer
> allocation. If this is -1, the pointer will be just freed.
> The functions mark and free will be called from garbage
> collector.
Yes, I suck at reading and can't write code properly as a result.
* http://unicorn.bogomips.org/
* mongrel-unicorn@rubyforge.org
* git://git.bogomips.org/unicorn.git
--
Eric Wong
next reply other threads:[~2010-02-13 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 10:34 Eric Wong [this message]
2010-02-13 10:37 ` [ANN] Rainbows! 0.90.2 - leak fix from Unicorn Eric Wong
[not found] ` <20100213103757.GB7833-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2010-02-13 10:39 ` [ANN] Zbatery 0.1.1 " Eric Wong
2010-03-01 18:55 ` [ANN] Rainbows! 0.91.0 - Unicorn resync Eric Wong
2010-03-01 18:58 ` [ANN] Zbatery 0.2.0 - Unicorn/Rainbows! resync Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/rainbows/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100213103409.GA7833@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=mongrel-unicorn@rubyforge.org \
--cc=rainbows-talk@rubyforge.org \
--cc=ruby-talk@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/rainbows.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).