Rainbows! Rack HTTP server user/dev discussion
 help / color / mirror / code / Atom feed
From: Lunar <lunar-L8VBg9NU5dbk1uMJSBkQmQ@public.gmane.org>
To: Rainbows! list <rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org>
Subject: Re: 'Connection reset by peer' when replying before the end of POST data
Date: Fri, 2 Mar 2012 17:03:53 +0100	[thread overview]
Message-ID: <20120302160353.GA21657@candra> (raw)
In-Reply-To: <20120229213601.GA7116-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>

Eric Wong wrote:
> Lunar <lunar@anargeek.net> wrote:
> > With your proposed patch, everything is working as intended. At least, I
> > can confirm Firefox correctly display the error message sent by the
> > server and not the less understandable "Connection reset by peer". I can
> > also confirm that it does not send the complete file: it looks like it
> > stops sending as soon as either it notices the socket is closed on its
> > write part, or when the response arrives. I am satisfied enough not to
> > dive in libxpcom…
> 
> Cool, thanks for confirming.  It's good that your client knows to back
> off.

Actually, they don't, I was a little too quick to answer. I made some
more test, sending a 8.1 MB file over a Wi-Fi connection between two
systems. For each test, I created a pcap file by recording the HTTP
transmission.

curl is 7.21.2-4, and I am using:

    curl -v -F "file=@test-file.xcf;type=application/x-xcf" \
            -F "submit=submit" http://webserver/

epiphany is 2.30.6-1, using WebKit and IIRC, libsoup for its HTTP
connections. Iceweasel is version 3.5.16-12. w3m is 0.5.2-10. All coming
from Debian Squeeze.

Here's what's hapenning for nginx (0.7.67-3+squeeze1) when
`client_max_body` is set to `1m`:

  - curl: 413 displayed, 9.5K
  - w3m: 413 displayed, 8.8M
  - iceweasel: 413 displayed, 8.8M
  - epiphany: 413 displayed, 8.8M

For Apache (2.2.16-6+squeeze6), using `LimitRequestBody 1048576`:

  - curl: 413 displayed, 1.8K
  - w3m: 413 displayed, 8.8M
  - iceweasel: 413 displayed, 8.9M
  - epiphany: 413 displayed, 8.8M

So it looks usual HTTP web server and clients will drain all the POST
input in order to display the error message. *sigh*


Then I set up Rainbows! with the following (running latest gems on Ruby
1.8.7):

--- 8< --- rainbows.conf -----------------------------------------------
Rainbows! do
  use :ThreadSpawn
  rewindable_input false
end
--- >8 -----------------------------------------------------------------

--- 8< --- rackup.ru ---------------------------------------------------
run lambda do |env|
  while env['rack.input'].read; end;
  [ 200, { 'Content-Type' => 'text/plain' }, [ 'OK' ] ]
end
--- >8 -----------------------------------------------------------------

Same tests with this configuration:

  - curl: OK displayed, 9.5M
  - w3m: OK displayed, 9.5M
  - iceweasel: OK displayed, 9.5M
  - epiphany: OK displayed, 11M

If I add `client_max_body_size 1024 * 1024` in rainbows.conf:

  - curl: 413 displayed, 1.4K
  - w3m: 413 displayed, 11K
  - iceweasel: connection reset by peer, 21K
  - epiphany: connection terminated unexpectedly, 20K

> My original patch isn't safe for bad clients that send continously.
> Below is a safer version of my original patch, can you see if it
> works?
> 
> diff --git a/lib/rainbows/client.rb b/lib/rainbows/client.rb
> index b456eca..1dcb6d4 100644
> --- a/lib/rainbows/client.rb
> +++ b/lib/rainbows/client.rb
> @@ -6,4 +6,16 @@ class Rainbows::Client < Kgio::Socket
>    include Rainbows::ProcessClient
>  
>    alias write kgio_write
> +
> +  def close
> +    close_write
> +    kgio_wait_readable(2)
> +    buf = ""
> +    case kgio_tryread(512, buf)
> +    when nil, Symbol
> +      break
> +    end while true
> +    ensure
> +      super
> +  end
>  end

Using this patch (actually, defining Rainbows::Client#close in
rackup.ru), I get:

  - curl: 413 displayed, 1.5K
  - w3m: 413 displayed, 17K
  - iceweasel: connection reset by peer, 19K
  - epiphany: connection terminated unexpectedly, 16K

I have tried to come up with something closer to what other webservers
do, and it looks like it (but I might have overlooked something):

  def close
    close_write
    buf = ""
    loop do
      kgio_wait_readable(2)
      break unless kgio_tryread(512, buf)
    end
    ensure
      super
  end

Using this, I get the following results:

  - curl: 413 displayed, 1.4K
  - w3m: 413 displayed, 8.8M
  - iceweasel: 413 displayed, 8.8M
  - epiphany: 413 displayed, 8.8M


This whole issue leaves me severely disappointed. It looks like I either
have to waste much of my users time (by forcing them to upload the whole
file) or leave them clueless if the file is too big (by cutting the
connection early, resulting in a "reset by peer message"). What a
choice…

Hope that helps,
-- 
Lunar
_______________________________________________
Rainbows! mailing list - rainbows-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying

  parent reply	other threads:[~2012-03-02 16:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 22:15 'Connection reset by peer' when replying before the end of POST data Lunar
2012-02-28 23:39 ` Eric Wong
     [not found]   ` <20120228233919.GA10168-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2012-02-29  7:22     ` Lunar
2012-02-29 17:23       ` Eric Wong
     [not found]         ` <20120229172315.GA26630-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2012-02-29 20:57           ` Lunar
2012-02-29 21:36             ` Eric Wong
     [not found]               ` <20120229213601.GA7116-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2012-03-02 16:03                 ` Lunar [this message]
2012-03-02 16:29                   ` Lunar
2012-03-02 21:05                     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/rainbows/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120302160353.GA21657@candra \
    --to=lunar-l8vbg9nu5dbk1umjsbkqmq@public.gmane.org \
    --cc=rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/rainbows.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).