From: Eric Wong <e@80x24.org>
To: rainbows-public@bogomips.org
Subject: [PATCH 1/5] http_parser: handle keepalive_requests internally
Date: Sat, 14 Nov 2015 02:47:21 +0000 [thread overview]
Message-ID: <20151114024725.24139-2-e@80x24.org> (raw)
In-Reply-To: <20151114024725.24139-1-e@80x24.org>
unicorn 5 dropped support for this, essentially allowing unlimited
persistent connections if we used the parser as-is.
Since most of our concurrency models cannot handle infinite
persistent connections without being vulnerable to DoS,
we must support keepalive_requests like nginx does.
---
lib/rainbows/http_parser.rb | 15 +++++++++++++++
lib/rainbows/http_server.rb | 4 ++--
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/lib/rainbows/http_parser.rb b/lib/rainbows/http_parser.rb
index ec55fe9..30a67cb 100644
--- a/lib/rainbows/http_parser.rb
+++ b/lib/rainbows/http_parser.rb
@@ -2,6 +2,21 @@
# :enddoc:
# avoid modifying Unicorn::HttpParser
class Rainbows::HttpParser < Unicorn::HttpParser
+ @keepalive_requests = 100
+ class << self
+ attr_accessor :keepalive_requests
+ end
+
+ def initialize(*args)
+ @keepalive_requests = self.class.keepalive_requests
+ super
+ end
+
+ def next?
+ return false if (@keepalive_requests -= 1) <= 0
+ super
+ end
+
def self.quit
alias_method :next?, :never!
end
diff --git a/lib/rainbows/http_server.rb b/lib/rainbows/http_server.rb
index 637710d..09f2589 100644
--- a/lib/rainbows/http_server.rb
+++ b/lib/rainbows/http_server.rb
@@ -92,11 +92,11 @@ class Rainbows::HttpServer < Unicorn::HttpServer
end
def keepalive_requests=(nr)
- Unicorn::HttpRequest.keepalive_requests = nr
+ Rainbows::HttpParser.keepalive_requests = nr
end
def keepalive_requests
- Unicorn::HttpRequest.keepalive_requests
+ Rainbows::HttpParser.keepalive_requests
end
def client_max_header_size=(bytes)
--
EW
next prev parent reply other threads:[~2015-11-14 2:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 2:47 [WIP 0/5] updates for unicorn 5 internal changes Eric Wong
2015-11-14 2:47 ` Eric Wong [this message]
2015-11-14 2:47 ` [PATCH 2/5] kill the moronic Status: header Eric Wong
2015-11-14 2:47 ` [PATCH 3/5] reflect changes in Rack::Utils::HTTP_STATUS_CODES Eric Wong
2015-11-14 2:47 ` [PATCH 4/5] reduce constant lookup dependencies Eric Wong
2015-11-14 2:47 ` [PATCH 5/5] http_parser: workaround hijack changes in unicorn 5 Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/rainbows/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151114024725.24139-2-e@80x24.org \
--to=e@80x24.org \
--cc=rainbows-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/rainbows.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).