Rainbows! Rack HTTP server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: rainbows-public@bogomips.org
Subject: [PATCH 5/5] response: simplify regexp
Date: Sat, 21 Nov 2015 08:52:32 +0000	[thread overview]
Message-ID: <20151121085232.23086-6-e@80x24.org> (raw)
In-Reply-To: <20151121085232.23086-1-e@80x24.org>

Redundant \z statements are ugly and wastes 4 bytes on x86-64
according to ObjectSpace.memsize_of
---
 lib/rainbows/response.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/rainbows/response.rb b/lib/rainbows/response.rb
index ac50321..62dfa39 100644
--- a/lib/rainbows/response.rb
+++ b/lib/rainbows/response.rb
@@ -30,7 +30,7 @@ def write_headers(status, headers, alive, body)
           "Date: #{httpdate}\r\n"
     headers.each do |key, value|
       case key
-      when %r{\A(?:Date\z|Connection\z)}i
+      when %r{\A(?:Date|Connection)\z}i
         next
       when "rack.hijack"
         # this was an illegal key in Rack < 1.5, so it should be
-- 
EW


      parent reply	other threads:[~2015-11-21  8:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-21  8:52 [PATCH 0/5] a few more odds and ends before 5.0 Eric Wong
2015-11-21  8:52 ` [PATCH 1/5] tiny bytecode reductions for cold paths Eric Wong
2015-11-21  8:52 ` [PATCH 2/5] Ruby 1.9.3+-only cleanups Eric Wong
2015-11-21  8:52 ` [PATCH 3/5] response: avoid garbage string entirely Eric Wong
2015-11-21  8:52 ` [PATCH 4/5] revactor: remove fcntl dependency Eric Wong
2015-11-21  8:52 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/rainbows/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151121085232.23086-6-e@80x24.org \
    --to=e@80x24.org \
    --cc=rainbows-public@bogomips.org \
    --subject='Re: [PATCH 5/5] response: simplify regexp' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	../../rainbows.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).