* [WIP 0/5] updates for unicorn 5 internal changes
@ 2015-11-14 2:47 5% Eric Wong
2015-11-14 2:47 7% ` [PATCH 3/5] reflect changes in Rack::Utils::HTTP_STATUS_CODES Eric Wong
0 siblings, 1 reply; 3+ results
From: Eric Wong @ 2015-11-14 2:47 UTC (permalink / raw)
To: rainbows-public
Only passes tests (using unicorn 4.x) so far. There is likely
more to do, but just publishing these changes early to give
folks some time to look at them over the weekend.
lib/rainbows/const.rb | 3 --
lib/rainbows/coolio/client.rb | 10 +++----
lib/rainbows/coolio/thread_client.rb | 6 ++--
lib/rainbows/dev_fd_response.rb | 22 ++++++--------
lib/rainbows/epoll/client.rb | 10 +++----
lib/rainbows/error.rb | 4 +--
lib/rainbows/ev_core.rb | 28 +++++++-----------
lib/rainbows/event_machine/client.rb | 14 ++++-----
lib/rainbows/event_machine/try_defer.rb | 5 +---
lib/rainbows/http_parser.rb | 24 ++++++++++++++++
lib/rainbows/http_server.rb | 4 +--
lib/rainbows/max_body.rb | 13 +++------
lib/rainbows/process_client.rb | 19 ++++++------
lib/rainbows/response.rb | 51 +++++++++++----------------------
lib/rainbows/reverse_proxy.rb | 28 ++++++------------
lib/rainbows/reverse_proxy/ev_client.rb | 7 ++---
lib/rainbows/sendfile.rb | 12 ++------
lib/rainbows/server_token.rb | 7 +----
lib/rainbows/stream_response_epoll.rb | 13 ++++-----
19 files changed, 119 insertions(+), 161 deletions(-)
[PATCH 1/5] http_parser: handle keepalive_requests internally
[PATCH 2/5] kill the moronic Status: header
[PATCH 3/5] reflect changes in Rack::Utils::HTTP_STATUS_CODES
[PATCH 4/5] reduce constant lookup dependencies
[PATCH 5/5] http_parser: workaround hijack changes in unicorn 5
^ permalink raw reply [relevance 5%]
* [PATCH 3/5] reflect changes in Rack::Utils::HTTP_STATUS_CODES
2015-11-14 2:47 5% [WIP 0/5] updates for unicorn 5 internal changes Eric Wong
@ 2015-11-14 2:47 7% ` Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2015-11-14 2:47 UTC (permalink / raw)
To: rainbows-public
Applications may want to alter the message associated with HTTP
status codes in Rack::Utils::HTTP_STATUS_CODES. Avoid memoizing
status lines ahead-of-time
Note: this introduces a minor performance regression, but ought to
be unnoticeable unless you're running "Hello world"-type apps.
---
lib/rainbows/response.rb | 5 +++--
lib/rainbows/stream_response_epoll.rb | 6 +++---
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/lib/rainbows/response.rb b/lib/rainbows/response.rb
index db14ee4..a661ab6 100644
--- a/lib/rainbows/response.rb
+++ b/lib/rainbows/response.rb
@@ -40,8 +40,9 @@ module Rainbows::Response
def write_headers(status, headers, alive, body)
@hp.headers? or return body
hijack = nil
- status = CODES[status.to_i] || status
- buf = "HTTP/1.1 #{status}\r\n" \
+ code = status.to_i
+ msg = Rack::Utils::HTTP_STATUS_CODES[code]
+ buf = "HTTP/1.1 #{msg ? %Q(#{code} #{msg}) : status}\r\n" \
"Date: #{httpdate}\r\n"
headers.each do |key, value|
case key
diff --git a/lib/rainbows/stream_response_epoll.rb b/lib/rainbows/stream_response_epoll.rb
index c0d90a4..1f32dcc 100644
--- a/lib/rainbows/stream_response_epoll.rb
+++ b/lib/rainbows/stream_response_epoll.rb
@@ -20,18 +20,18 @@ require "raindrops"
# * sleepy_penguin 3.0.1 or later
module Rainbows::StreamResponseEpoll
# :stopdoc:
- CODES = Unicorn::HttpResponse::CODES
HEADER_END = "X-Accel-Buffering: no\r\n\r\n"
autoload :Client, "rainbows/stream_response_epoll/client"
def http_response_write(socket, status, headers, body)
- status = CODES[status.to_i] || status
hijack = ep_client = false
if headers
# don't set extra headers here, this is only intended for
# consuming by nginx.
- buf = "HTTP/1.0 #{status}\r\n"
+ code = status.to_i
+ msg = Rack::Utils::HTTP_STATUS_CODES[code]
+ buf = "HTTP/1.0 #{msg ? %Q(#{code} #{msg}) : status}\r\n"
headers.each do |key, value|
case key
when "rack.hijack"
--
EW
^ permalink raw reply related [relevance 7%]
* [ANN] Rainbows! 5.0.0 - Rack HTTP server for the sleepy
@ 2015-11-25 1:04 4% Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2015-11-25 1:04 UTC (permalink / raw)
To: ruby-talk; +Cc: rainbows-public
Rainbows! is an HTTP server for sleepy Rack applications.
While it will be maintained as long as anybody uses it,
use of Rainbows! for new projects is not recommended,
try other servers instead:
http://bogomips.org/rainbows-public/20151020095934.GA19114@dcvr.yhbt.net/
Rainbows! 5.0.0 - maintained as long as anybody uses it!
This release syncs with unicorn 5 and drops some old compatibility
cruft from old releases. Performance should be roughly unchanged
for Ruby 2.2 users while older Rubies (1.9.3 - 2.1) will see
minor, probably unnoticeable performance regressions.
Compatibility:
* The horrible, proprietary (:P) "Status:" response header is
finally gone, saving at least 16 precious bytes in every HTTP
response. This should make it easier to write custom HTTP clients
which are compatible across all HTTP servers. It will hopefully
make migrating between different Rack servers easier for new
projects.
* Ruby 1.8 support removed. Ruby 1.9.3 is currently the earliest
supported version. However, expect minor, likely-unnoticeable
performance regressions if you use Ruby 2.1 or earlier. Going
forward, Rainbows! will favor the latest version (currently 2.2) of
the mainline Ruby implementation, potentially sacrificing
performance on older Rubies.
New features:
* sd_listen_fds(3) emulation added for systemd compatibility.
You may now stop using PID files and other process monitoring
software when using systemd.
* Newly-set TCP socket options are now applied to inherited sockets.
* Dynamic changes in the application to Rack::Utils::HTTP_STATUS
hash is now supported; allowing users to set custom status lines
in Rack to be reflected in unicorn. This feature causes a minor
performance regression, but is made up for Ruby 2.2 users with
other optimizations.
* The monotonic clock is used under Ruby 2.1+, making the
timeout feature immune to system clock changes.
As Rainbows! may be used anonymously without registration, the
project is committed to supporting anonymous and pseudonymous
help requests, contributions and feedback via plain-text mail to:
rainbows-public@bogomips.org
The mail submission port (587) is open to those behind firewalls
and allows access via Tor and anonymous remailers.
Archives are accessible via:
* http://bogomips.org/rainbows-public/
* nntp://news.public-inbox.org/inbox.comp.lang.ruby.rainbows
* nntp://news.gmane.org/gmane.comp.lang.ruby.rainbows.general
and mirrored to various other places, so you do not even need
to use a valid address when posting.
18 changes since Rainbows! 4.7.0
README: remove Zbatery references
http_parser: handle keepalive_requests internally
kill the moronic Status: header
reflect changes in Rack::Utils::HTTP_STATUS_CODES
reduce constant lookup dependencies
http_parser: workaround hijack changes in unicorn 5
http_server: add master_pid attribute
stream_response_epoll: remove hijack_prepare call
bump to unicorn 5.0.1, use monotonic clock
add .gitattributes for Ruby method detection
response: avoid garbage string entirely
tiny bytecode reductions for cold paths
Ruby 1.9.3+-only cleanups
revactor: remove fcntl dependency
response: simplify regexp
t0105: fix test reliability
fix Rainbows.now definition for old Rubies
fix broken constant lookups in unmaintained bits
* http://rainbows.bogomips.org/
* rainbows-public@bogomips.org
* http://bogomips.org/rainbows-public/
* git clone git://bogomips.org/rainbows.git
* http://rainbows.bogomips.org/NEWS.atom.xml
*zzzzzzzz*
^ permalink raw reply [relevance 4%]
Results 1-3 of 3 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2015-11-14 2:47 5% [WIP 0/5] updates for unicorn 5 internal changes Eric Wong
2015-11-14 2:47 7% ` [PATCH 3/5] reflect changes in Rack::Utils::HTTP_STATUS_CODES Eric Wong
2015-11-25 1:04 4% [ANN] Rainbows! 5.0.0 - Rack HTTP server for the sleepy Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/rainbows.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).