From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS33070 50.56.128.0/17 X-Spam-Status: No, score=0.8 required=3.0 tests=AWL,MSGID_FROM_MTA_HEADER, RDNS_NONE shortcircuit=no autolearn=no version=3.3.2 Path: news.gmane.org!not-for-mail From: "Lin Jen-Shin (godfat)" Newsgroups: gmane.comp.lang.ruby.rainbows.general Subject: Re: [PATCH] Match against newer curl. Date: Wed, 25 Sep 2013 19:00:37 +0800 Message-ID: References: <1379004076-69752-1-git-send-email-godfat@godfat.org> <20130925014657.GA21892@dcvr.yhbt.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1380106879 22826 80.91.229.3 (25 Sep 2013 11:01:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Sep 2013 11:01:19 +0000 (UTC) Cc: Rainbows! list To: Eric Wong Original-X-From: rainbows-talk-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Wed Sep 25 13:01:24 2013 Return-path: Envelope-to: gclrrg-rainbows-talk@m.gmane.org X-Original-To: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Delivered-To: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=godfat.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=6wT+fyg0QICBVj8El5i9yYlmR89E/FTZM2INZPonGc8=; b=fBY8NbwJsRGvk9chEOunDdYyz6vSzgnutEdV9amCW3oHxEgsk7NNaZUboN4sDpndYq Gscu0/HGUu9tz+fJv4tN67qZcl9m7Dcqu/r/vL3ZqnYa9H6pxg+7uldTES+nNPpZgRyS EhAB49Fla+/kqnaVnKpxHxBlActAyAH84IpgA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=6wT+fyg0QICBVj8El5i9yYlmR89E/FTZM2INZPonGc8=; b=BFmLe0NNXj4dRpBFKdiEoV7BNra3sZzBAQHxwuTahy2eni0xYfTNcS1HDB9BPYNbEc WZLklhbGrobnvjVm7hSG9UKXtje+Ff+R65+qEfajp07Ki4LNfJzjncOxY59h5paA5vao JOcCHroj2qJICelgLxbSs0eo03QfQHZyZPiZ/qGchOpXcqbIGHmecCt2Mo4TWXiIFcFF c/SSJF+hHjPLdKtueR63EE2fah5eY6P1+TVoIKWTnfzklyTLRu3ZUaeZD1oBPreHNGYf jBllJ+/0WkqpJzdCQnxFwfaJar9Frj3PxjX+Rm3BAg/WN9jJV7QeKh7cYx1wpMkdsQvz ZYPQ== X-Gm-Message-State: ALoCoQm4gUh+vkvVeLI9OpSKfU2xhora5u0nKcCjge60a9S4fT54d9YEIX5stY/iB/H1hNFHDYFi X-Received: by 10.14.126.69 with SMTP id a45mr2202727eei.65.1380106868109; Wed, 25 Sep 2013 04:01:08 -0700 (PDT) In-Reply-To: <20130925014657.GA21892-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org> X-BeenThere: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: rainbows-talk-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Errors-To: rainbows-talk-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org X-Broken-Reverse-DNS: no host name found for IP address 50.56.192.79 Xref: news.gmane.org gmane.comp.lang.ruby.rainbows.general:547 Archived-At: Received: from [50.56.192.79] (helo=rubyforge.org) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VOmqQ-0006pJ-VM for gclrrg-rainbows-talk@m.gmane.org; Wed, 25 Sep 2013 13:01:23 +0200 Received: from localhost.localdomain (localhost [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id D01D82E22D; Wed, 25 Sep 2013 11:01:21 +0000 (UTC) Received: from mail-ea0-f175.google.com (mail-ea0-f175.google.com [209.85.215.175]) by rubyforge.org (Postfix) with ESMTP id AC4E92E20D for ; Wed, 25 Sep 2013 11:01:09 +0000 (UTC) Received: by mail-ea0-f175.google.com with SMTP id m14so3074052eaj.6 for ; Wed, 25 Sep 2013 04:01:08 -0700 (PDT) Received: by 10.223.200.132 with HTTP; Wed, 25 Sep 2013 04:00:37 -0700 (PDT) On Wed, Sep 25, 2013 at 9:46 AM, Eric Wong wrote: > Lin Jen-Shin wrote: >> My curl 7.32.0 would actually print 400 Bad Request >> Hope this would make it match against newer or older curl. >> --- >> t/t0045-client_max_header_size.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/t/t0045-client_max_header_size.sh b/t/t0045-client_max_header_size.sh >> index cd8f1fe..320fe0c 100755 >> --- a/t/t0045-client_max_header_size.sh >> +++ b/t/t0045-client_max_header_size.sh >> @@ -60,7 +60,7 @@ t_begin "smallest HTTP/0.9 request works right" && { >> >> t_begin "HTTP/1.1 request fails" && { >> curl -vsSf http://$listen/ > $tmp 2>&1 && die "unexpected curl success" >> - grep '400$' $tmp >> + grep '400\( Bad Request\)\?$' $tmp > > I think thse cases should just use "--write-out %{http_code}" instead. > Theres probably a bunch of places where we should be doing this, really. > --write-out has been around for at least 10 years, so I think it's safe > to use. Great. Just checked it and it worked. What about introducing http_status() utility function in this case? I could do this. > Also, I notice this got combined into your EventMachineThread* patch. Yeah, I haven't written any document as the other concurrency models, either. Since it seems I did something wrong, and the tests could not pass completely for some reasons, I chose to send the patch first anyway :( Sorry I should have mentioned this. _______________________________________________ Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org http://rubyforge.org/mailman/listinfo/rainbows-talk Do not quote signatures (like this one) or top post when replying