From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS33070 50.56.128.0/17 X-Spam-Status: No, score=0.0 required=3.0 tests=AWL,MSGID_FROM_MTA_HEADER, TVD_RCVD_IP shortcircuit=no autolearn=unavailable version=3.3.2 Path: news.gmane.org!not-for-mail From: "Lin Jen-Shin (godfat)" Newsgroups: gmane.comp.lang.ruby.rainbows.general Subject: Re: [PATCH] close_connection_after_writing only if not deferred, as in cool.io Date: Fri, 28 Dec 2012 12:45:24 +0800 Message-ID: References: <20121218214538.GA12275@dcvr.yhbt.net> <20121218235954.GA14404@dcvr.yhbt.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1356669966 23691 80.91.229.3 (28 Dec 2012 04:46:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 28 Dec 2012 04:46:06 +0000 (UTC) To: "Rainbows! list" Original-X-From: rainbows-talk-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Fri Dec 28 05:46:22 2012 Return-path: Envelope-to: gclrrg-rainbows-talk@m.gmane.org X-Original-To: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Delivered-To: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=godfat.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=hZxiHJmzROPQF7TEnvNbkWE5D+AgK2e9GL63IYZKPNs=; b=0xlksYZl0xgH8EfAH00kTtAQ5D9heZuk7aiYxBKn+AEGlGWhGY9cxkAk1NLQqWv4Ag Tdq22a8Qdv2sJmH8y5xwczx3TvOGR+QgJex4UY7d5kWeVZm+z6thM4IOOdo1jslh2Ycd kczw1yVIqW2DHKjkZvMhq24DFJjkjFqMWnjfo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:x-gm-message-state; bh=hZxiHJmzROPQF7TEnvNbkWE5D+AgK2e9GL63IYZKPNs=; b=pdYf4kGbG1NCi6TC4n3kCn1NrbC5UQ90NOHmS65dz5cdk+VxyoG0ef16v1z6wOJfIf cZM3tpNWnrfKAxmX6TT/4O5nY3bD5VJjr0juOzyYFuWnoi6DonxLO/pwrdDDubWhB7my OWPDGlU/WeLXsbfFkeD4Z7Lo3JLmP3u4lhwdhevKqrsbz8NBOi3Vv/9XvBxhH5ZPNYHg 0KcuIj+Gjf102BVeBXkguZpgI97f8g9k1QT1Uwd5Ilgx5q2EfYfOMi5hVl3l8cnSOJDh 7RckAc03fVMf4skKmJ+HOT1w+yuWsDCYEoHJxx2ZZx9EnplLeXrDzXq+mH2JQ51yGG8I tMpA== In-Reply-To: <20121218235954.GA14404-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org> X-Gm-Message-State: ALoCoQnKs1pfsuzZigtssRPTBHY6wuyUwCeVG+Hcww7JfEaM/udmYMg+JlvTmruHfn39LaX5NPcR X-BeenThere: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: rainbows-talk-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Errors-To: rainbows-talk-bounces-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org Xref: news.gmane.org gmane.comp.lang.ruby.rainbows.general:426 Archived-At: Received: from 50-56-192-79.static.cloud-ips.com ([50.56.192.79] helo=rubyforge.org) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ToRpq-0001Fi-Vr for gclrrg-rainbows-talk@m.gmane.org; Fri, 28 Dec 2012 05:46:19 +0100 Received: from localhost.localdomain (localhost [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 6BB9E2E096; Fri, 28 Dec 2012 04:46:03 +0000 (UTC) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com [209.85.215.41]) by rubyforge.org (Postfix) with ESMTP id 296FE2E083 for ; Fri, 28 Dec 2012 04:45:55 +0000 (UTC) Received: by mail-la0-f41.google.com with SMTP id em20so273958lab.28 for ; Thu, 27 Dec 2012 20:45:55 -0800 (PST) Received: by 10.152.109.139 with SMTP id hs11mr30530326lab.13.1356669954872; Thu, 27 Dec 2012 20:45:54 -0800 (PST) Received: by 10.114.2.240 with HTTP; Thu, 27 Dec 2012 20:45:24 -0800 (PST) On Wed, Dec 19, 2012 at 7:59 AM, Eric Wong wrote: > I've had no trouble running tests with various Linux distros. > It's been a long time since I've tested on FreeBSD, and I've > not tested on any other *BSD. I cannot support non-Free OSes. > > Anything in the *err logs? The tests should leave them around on > failure. >>From last time I checked, there's nothing left in the log. I would guess it's because some command line tools behave differently, but Rainbows should work fine. Here's what I need to comment out: (3 tests, ab, rack-fiber_pool, and "Content-Length is set correctly in headers" (I guess it's grep behave differently. I could try to install GNU's version and try again.) diff --git a/t/t0012-spurious-wakeups-quiet.sh b/t/t0012-spurious-wakeups-quiet.sh index 23557b7..b63870f 100755 --- a/t/t0012-spurious-wakeups-quiet.sh +++ b/t/t0012-spurious-wakeups-quiet.sh @@ -10,11 +10,11 @@ then AB=$(PATH=/usr/local/sbin:/usr/sbin:$PATH which ab 2>/dev/null || :) fi -if test -z "$AB" -then +#if test -z "$AB" +#then t_info "skipping $T since 'ab' could not be found" exit 0 -fi +#fi t_plan 4 "quiet spurious wakeups for $model" diff --git a/t/t0600-rack-fiber_pool.sh b/t/t0600-rack-fiber_pool.sh index 01f28b5..ca8fcb1 100755 --- a/t/t0600-rack-fiber_pool.sh +++ b/t/t0600-rack-fiber_pool.sh @@ -10,7 +10,7 @@ esac require_check rack/fiber_pool Rack::FiberPool -t_plan 7 "basic test with rack-fiber_pool gem" +t_plan 6 "basic test with rack-fiber_pool gem" CONFIG_RU=rack-fiber_pool/app.ru @@ -42,8 +42,8 @@ t_begin "no errors from curl" && { t_begin "no errors in stderr" && check_stderr -t_begin "ensure we hit 3 separate fibers" && { - test x3 = x"$(sort < $curl_out | uniq | wc -l)" -} +# t_begin "ensure we hit 3 separate fibers" && { +# test x3 = x"$(sort < $curl_out | uniq | wc -l)" +# } t_done diff --git a/t/t9001-sendfile-to-path.sh b/t/t9001-sendfile-to-path.sh index 5a9fdcd..7ca450a 100755 --- a/t/t9001-sendfile-to-path.sh +++ b/t/t9001-sendfile-to-path.sh @@ -2,7 +2,7 @@ . ./test-lib.sh skip_models StreamResponseEpoll -t_plan 7 "Sendfile middleware test for $model" +t_plan 6 "Sendfile middleware test for $model" t_begin "configure and start" && { rtmpfiles curl_err @@ -39,9 +39,9 @@ t_begin "X-Sendfile does not show up in headers" && { fi } -t_begin "Content-Length is set correctly in headers" && { - expect=$(wc -c < random_blob) - grep "^< Content-Length: $expect" $curl_err -} +# t_begin "Content-Length is set correctly in headers" && { +# expect=$(wc -c < random_blob) +# grep "^< Content-Length: $expect" $curl_err +# } t_done _______________________________________________ Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org http://rubyforge.org/mailman/listinfo/rainbows-talk Do not quote signatures (like this one) or top post when replying