From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS15169 74.125.0.0/16 X-Spam-Status: No, score=-2.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7E0202018F for ; Wed, 13 Jul 2016 19:51:51 +0000 (UTC) Received: by mail-wm0-f48.google.com with SMTP id i5so84801719wmg.0 for ; Wed, 13 Jul 2016 12:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oblong.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=O6srPGeMTJvbrGu+Sr5r1b0QRCxCThoa/q6fRHxKFzE=; b=H8PWR3VlPQyuDhYp81c1KCC/ldfmScOirJ4GGsH7NjSIdw6RPOq/pCAlUF0eQbwJsx ypIzXyfKUDvNtTJssO2Ftdenl6mc7Lk8Kuohxa3D/CDfVMNSQJc85fA/nOiUpCTFelWb QMXxY4H2AOgjNZtTPFE6IWe4jW6mj7R+tBOWA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=O6srPGeMTJvbrGu+Sr5r1b0QRCxCThoa/q6fRHxKFzE=; b=PkxU/Auvzd8jTDDz/rhLK4Cw+5He1ZHX04qdXzUKncRdgI4/fAWmBLUdOiqBC+FmdR eMphmoZZ2rbOyxXvK9xO78TQBHkPEIlJESmuoHE2A0YTyHHosK6HQkqbNrDaYP4IbDwK Wbx2NpyKZxmFSQIsmTnCWcYz4ThMfm35Dd0vJ0tEktAv+u/++1J8HUOcd5Q0H5hICi5k WRrkkAcZoJ8lU2weQVR3wg9MxLopPKMERlbsg4rwzRr7bC+jucd2+WTgIMX5QpPQjGwD MY0Tth+CxshwRYCo2T1d/2BWuba3qbMdvNsKFlvSXU/RXklK6F4Os+VvkR0hNxg5nEfF 4sxA== X-Gm-Message-State: ALyK8tKxEKU4txjE4MjklcGi+gUXM4yYQYTORkl0PZQw2Vt3yf15pxga4QrkjENCL1bSp6A4xiXQ8Qt0gayBhy7v X-Received: by 10.28.145.17 with SMTP id t17mr12796802wmd.14.1468439510015; Wed, 13 Jul 2016 12:51:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.193.3 with HTTP; Wed, 13 Jul 2016 12:51:35 -0700 (PDT) From: Kevin Mullican Date: Wed, 13 Jul 2016 12:51:35 -0700 Message-ID: Subject: issue between rainbows/unicorn 5.0.0 and rack on ruby >= 1.9.1 To: rainbows-public@bogomips.org Content-Type: text/plain; charset=UTF-8 List-Id: Greetings, We have run into a problem while trying to use rainbows/unicorn 5.0.0 on ruby >= 1.9.1. The issue is with rack. As of ruby 1.9.1, String no longer responds to #each, however it seems that rainbows is still sending a string body through rack. See: rainbows-5.0.0/lib/rainbows/process_client.rb:51: in `write_response` which enters rack at: rainbows-5.0.0/lib/rainbows/response.rb:85:in `write_body_each' Note that the rack spec specifically requires that body respond to #each and yield a set of strings: https://github.com/rack/rack/blob/25a549883b85fb33970b4a1530a365c0c9e51f95/SPEC#L245-L248 So, it seems that the onus is likely on rainbows to conform to the rack spec in order to require it's use. One solution would be to wrap the bare string in an array before it descends into rack. Sincerely, Kevin Mullican