Rainbows! Rack HTTP server user/dev discussion
 help / color / mirror / code / Atom feed
* issue between rainbows/unicorn 5.0.0 and rack on ruby >= 1.9.1
@ 2016-07-13 19:51 Kevin Mullican
  2016-07-13 20:24 ` Eric Wong
  0 siblings, 1 reply; 4+ messages in thread
From: Kevin Mullican @ 2016-07-13 19:51 UTC (permalink / raw)
  To: rainbows-public


We have run into a problem while trying to use rainbows/unicorn 5.0.0
on ruby >= 1.9.1. The issue is with rack. As of ruby 1.9.1, String no
longer responds to #each, however it seems that rainbows is still
sending a string body through rack. See:

rainbows-5.0.0/lib/rainbows/process_client.rb:51: in `write_response`

which enters rack at:

rainbows-5.0.0/lib/rainbows/response.rb:85:in `write_body_each'

Note that the rack spec specifically requires that body respond to
#each and yield a set of strings:


So, it seems that the onus is likely on rainbows to conform to the
rack spec in order to require it's use. One solution would be to wrap
the bare string in an array before it descends into rack.

Kevin Mullican

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-07-14 22:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-13 19:51 issue between rainbows/unicorn 5.0.0 and rack on ruby >= 1.9.1 Kevin Mullican
2016-07-13 20:24 ` Eric Wong
2016-07-14 16:13   ` Dan Kegel
2016-07-14 22:17     ` Eric Wong

Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).