about summary refs log tree commit homepage
diff options
authorEric Wong <normalperson@yhbt.net>2010-08-28 06:11:45 +0000
committerEric Wong <normalperson@yhbt.net>2010-08-28 06:18:14 +0000
commit108d6afd7ff390bb594c99ba23c91163fa98d8c0 (patch)
parent33eeda85248c9132366f94f1e1a83365bb33b5a7 (diff)
Rack::Lint uses String#inspect to generate assertion messages
whether or not the assertions are triggered at all.
Unfortunately String#inspect is hilariously slow under 1.9.2
when dealing with odd characters and large strings.

The performance difference is huge:

	before: 1m4.386s
	 after: 0m3.877s

We already have Rack::Lint enabled everywhere else, so removing
this where performance matters most shouldn't hurt us.
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t0016-onenine-encoding-is-tricky.sh b/t/t0016-onenine-encoding-is-tricky.sh
index 8757e43..07ebcee 100755
--- a/t/t0016-onenine-encoding-is-tricky.sh
+++ b/t/t0016-onenine-encoding-is-tricky.sh
@@ -4,7 +4,7 @@ t_plan 4 "proper handling of onenine encoding for $model"
 t_begin "setup and startup" && {
         rainbows_setup $model
-        rainbows -D ./t0016.rb -c $unicorn_config
+        rainbows -E none -D ./t0016.rb -c $unicorn_config