byte_slice: String#[range] is faster than String#slice!(range)

rb_str_slice_bang() allocates a new string internally and calls
rb_str_aref_m() AND rb_str_aset_m(), too.  String#[] just
calls rb_str_aref_m() directly, so it's a much quicker code
path.  Also, "[]" methods dispatch faster under 1.9, too.

1 files changed, 1 insertions, 1 deletions

diff --git a/lib/rainbows/byte_slice.rb b/lib/rainbows/byte_slice.rb
index 09d1188..2d5586c 100644
--- a/lib/rainbows/byte_slice.rb
+++ b/lib/rainbows/byte_slice.rb
@@ -3,7 +3,7 @@ module Rainbows::ByteSlice
   if String.method_defined?(:encoding)
     def byte_slice(buf, range)
       if buf.encoding != Encoding::BINARY
-        buf.dup.force_encoding(Encoding::BINARY).slice!(range)
+        buf.dup.force_encoding(Encoding::BINARY)[range]
       else
         buf[range]
       end