From 6edaf2b720743fa0ce751b45a0923712b8ed5909 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 14 Oct 2009 17:39:10 -0700 Subject: rack.multithread is only true for Thread* models Enabling thread-safe or thread-aware code paths in applications may even be dangerous in some cases and cause deadlocks in code that otherwise does not expect threads. This is especially true of the Revactor case where being a "drop-in" replacement for IO routines is dangerous if a mutex is held while an Actor performs a "blocking" I/O operation. Basically start to assume that anybody writing an app using Rev or Revactor already takes Rev/Revactor concurrency into account and won't need the rack.multithread flag set to do special things. --- lib/rainbows/const.rb | 5 ----- 1 file changed, 5 deletions(-) (limited to 'lib/rainbows/const.rb') diff --git a/lib/rainbows/const.rb b/lib/rainbows/const.rb index 1b5c3a8..648d90e 100644 --- a/lib/rainbows/const.rb +++ b/lib/rainbows/const.rb @@ -8,11 +8,6 @@ module Rainbows include Unicorn::Const RACK_DEFAULTS = ::Unicorn::HttpRequest::DEFAULTS.merge({ - - # we need to observe many of the rules for thread-safety even - # with Revactor or Rev, so we're considered multithread-ed even - # when we're not technically... - "rack.multithread" => true, "SERVER_SOFTWARE" => "Rainbows! #{RAINBOWS_VERSION}", }) -- cgit v1.2.3-24-ge0c7