From 1468604be898d17c2cf2da519dccd493c58f4282 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 10 Jun 2011 22:08:04 +0000 Subject: ev_core: do not autochunk HTTP/1.0 (and 0.9) responses Do not assume middlewares/applications are stupid and blindly add chunking to responses (we have precedence set by Rack::Chunked). --- lib/rainbows/dev_fd_response.rb | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'lib/rainbows/dev_fd_response.rb') diff --git a/lib/rainbows/dev_fd_response.rb b/lib/rainbows/dev_fd_response.rb index eaa4af4..edc39af 100644 --- a/lib/rainbows/dev_fd_response.rb +++ b/lib/rainbows/dev_fd_response.rb @@ -19,7 +19,6 @@ class Rainbows::DevFdResponse < Struct.new(:app) Transfer_Encoding = "Transfer-Encoding".freeze Rainbows_autochunk = "rainbows.autochunk".freeze Rainbows_model = "rainbows.model" - HTTP_1_0 = "HTTP/1.0" HTTP_VERSION = "HTTP_VERSION" Chunked = "chunked" @@ -55,8 +54,12 @@ class Rainbows::DevFdResponse < Struct.new(:app) headers.delete(Transfer_Encoding) elsif st.pipe? || st.socket? # epoll-able things unless headers.include?(Content_Length) - if env[Rainbows_autochunk] && HTTP_1_0 != env[HTTP_VERSION] - headers[Transfer_Encoding] = Chunked + if env[Rainbows_autochunk] + case env[HTTP_VERSION] + when "HTTP/1.0", nil + else + headers[Transfer_Encoding] = Chunked + end else env[Rainbows_autochunk] = false end -- cgit v1.2.3-24-ge0c7