From 015635f877084cc05a9e6e4c1430c70279d0a04e Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 28 Oct 2010 08:40:12 +0000 Subject: tests: avoid race conditions on reload tests We need to ensure the old worker is really dead before sending requests after reloading. --- t/t0018-reload-restore-settings.sh | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) (limited to 't/t0018-reload-restore-settings.sh') diff --git a/t/t0018-reload-restore-settings.sh b/t/t0018-reload-restore-settings.sh index 24ee406..3a9471f 100644 --- a/t/t0018-reload-restore-settings.sh +++ b/t/t0018-reload-restore-settings.sh @@ -19,16 +19,8 @@ t_begin "clobber config and reload" && { stderr_path "$r_err" EOF kill -HUP $rainbows_pid - while ! egrep '(done|error) reloading' $r_err >/dev/null - do - sleep 1 - done - - grep 'done reloading' $r_err >/dev/null - while ! grep reaped $r_err >/dev/null - do - sleep 1 - done + wait_for_reload + wait_for_reap } t_begin "HTTP request confirms we're on the default model" && { @@ -41,15 +33,8 @@ t_begin "restore config and reload" && { > $r_err kill -HUP $rainbows_pid rainbows_wait_start - while ! egrep '(done|error) reloading' $r_err >/dev/null - do - sleep 1 - done - while ! grep reaped $r_err >/dev/null - do - sleep 1 - done - grep 'done reloading' $r_err >/dev/null + wait_for_reload + wait_for_reap } t_begin "HTTP request confirms we're back on the correct model" && { -- cgit v1.2.3-24-ge0c7