From 5531ceb42a993ef8a68ed557fc77d052b89bccfb Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 19 Oct 2009 20:46:34 -0700 Subject: rev: fix static file responses under HTTP/0.9 Since HTTP/0.9 responses have no headers to write, the on_write_complete handler we rely on never got triggered, leading to additional reads to never get queued up. Additionally, we need to explicitly detect and close client sockets if we've written the last response body since HTTP/0.9 clients never know when it's time to close a connection. --- t/lib-large-file-response.sh | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) (limited to 't') diff --git a/t/lib-large-file-response.sh b/t/lib-large-file-response.sh index 830812a..9866982 100644 --- a/t/lib-large-file-response.sh +++ b/t/lib-large-file-response.sh @@ -7,7 +7,7 @@ then fi echo "large file response slurp avoidance for model=$model" eval $(unused_listen) -rtmpfiles unicorn_config tmp r_err r_out pid ok +rtmpfiles unicorn_config tmp r_err r_out pid ok fifo cat > $unicorn_config < $ok) | wc -c) + size=$( (curl -sSfv http://$listen/random_blob && echo ok >$ok) |wc -c) test $size -eq $random_blob_size test xok = x$(cat $ok) done +echo "HTTP/1.0 test" # this was a problem during development +size=$( (curl -0 -sSfv http://$listen/random_blob && echo ok >$ok) |wc -c) +test $size -eq $random_blob_size +test xok = x$(cat $ok) + +echo "HTTP/0.9 test" +( + printf 'GET /random_blob\r\n' + cat $fifo > $tmp & + wait + echo ok > $ok +) | socat - TCP:$listen > $fifo +cmp $tmp random_blob +test xok = x$(cat $ok) + dbgcat r_err curl -v http://$listen/rss rss_after=$(curl -sSfv http://$listen/rss) -- cgit v1.2.3-24-ge0c7