From: Eric Wong <normalperson@yhbt.net> To: raindrops@librelist.org Subject: [PATCH 1/3] raindrops: favor configured processor count over online count Date: Thu, 11 Apr 2013 23:28:22 +0000 Message-ID: <1365722904-889-1-git-send-email-normalperson@yhbt.net> (raw) In-Reply-To: <1365722904-889-1-git-send-email-normalperson@yhbt.net> The runnable CPUs of a process may change over the lifetime of the process. So favor the count of configured processor count since that is more likely to be stable. We do not currently do not have special handling for hot-plugging/removal of CPUs on systems that may load raindrops in a single CPU state. --- ext/raindrops/raindrops.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/ext/raindrops/raindrops.c b/ext/raindrops/raindrops.c index 6cc0d12..65c16e7 100644 --- a/ext/raindrops/raindrops.c +++ b/ext/raindrops/raindrops.c @@ -326,11 +326,13 @@ void Init_raindrops_linux_inet_diag(void); void Init_raindrops_linux_tcp_info(void); #endif -#ifndef _SC_NPROCESSORS_ONLN -# ifdef _SC_NPROC_ONLN -# define _SC_NPROCESSORS_ONLN _SC_NPROC_ONLN +#ifndef _SC_NPROCESSORS_CONF +# if defined _SC_NPROCESSORS_ONLN +# define _SC_NPROCESSORS_CONF _SC_NPROCESSORS_ONLN +# elif defined _SC_NPROC_ONLN +# define _SC_NPROCESSORS_CONF _SC_NPROC_ONLN # elif defined _SC_CRAY_NCPU -# define _SC_NPROCESSORS_ONLN _SC_CRAY_NCPU +# define _SC_NPROCESSORS_CONF _SC_CRAY_NCPU # endif #endif @@ -359,8 +361,8 @@ void Init_raindrops_ext(void) VALUE cRaindrops = rb_define_class("Raindrops", rb_cObject); long tmp = 2; -#ifdef _SC_NPROCESSORS_ONLN - tmp = sysconf(_SC_NPROCESSORS_ONLN); +#ifdef _SC_NPROCESSORS_CONF + tmp = sysconf(_SC_NPROCESSORS_CONF); #endif /* no point in padding on single CPU machines */ if (tmp == 1) -- 1.8.2.279.g631bc94
next parent reply other threads:[~2013-04-11 23:29 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-04-11 23:28 Eric Wong [this message] 2013-04-11 23:28 ` [PATCH 2/3] watcher: set Content-Type via assignment Eric Wong 2013-04-11 23:28 ` [PATCH 3/3] Linux::TCP_Info: implement #get! instance method Eric Wong 2013-04-11 23:30 ` [PATCH 1/3] raindrops: favor configured processor count over online count Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://yhbt.net/raindrops/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1365722904-889-1-git-send-email-normalperson@yhbt.net \ --to=normalperson@yhbt.net \ --cc=raindrops@librelist.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
raindrops RubyGem user+dev discussion/patches/pulls/bugs/help This inbox may be cloned and mirrored by anyone: git clone --mirror https://yhbt.net/raindrops-public git clone --mirror http://ou63pmih66umazou.onion/raindrops-public # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 raindrops-public raindrops-public/ https://yhbt.net/raindrops-public \ raindrops-public@yhbt.net raindrops-public@bogomips.org raindrops@librelist.org raindrops@librelist.com public-inbox-index raindrops-public Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.lang.ruby.raindrops nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.raindrops note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: ../../raindrops.git AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git