From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS6939 64.71.128.0/18
X-Spam-Status: No, score=-1.9 required=3.0 tests=AWL,BAYES_00,
 MSGID_FROM_MTA_HEADER shortcircuit=no autolearn=unavailable version=3.3.2
Path: news.gmane.org!not-for-mail
From: Eric Wong <normalperson@yhbt.net>
Newsgroups: gmane.comp.lang.ruby.raindrops.general
Subject: testers on 32-bit FreeBSD wanted
Date: Thu, 10 May 2012 21:54:57 +0000
Message-ID: <20120510215457.GA11961@dcvr.yhbt.net>
References: <20120510215457.GA11961@dcvr.yhbt.net>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Trace: dough.gmane.org 1336686923 10304 80.91.229.3 (10 May 2012 21:55:23
 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Thu, 10 May 2012 21:55:23 +0000 (UTC)
To: raindrops@librelist.org
Original-X-From: raindrops@librelist.org Thu May 10 23:55:21 2012
Return-path: <raindrops@librelist.org>
Envelope-to: gclrrg-raindrops@m.gmane.org
In-Reply-To: <20120510215457.GA11961@dcvr.yhbt.net>
List-Archive: <http://librelist.com/archives/raindrops/>
List-Help: <http://librelist.com/help.html>
List-Id: <raindrops-public@bogomips.org>
List-Post: <mailto:raindrops@librelist.org>
List-Subscribe: <mailto:raindrops-subscribe@librelist.com>
List-Unsubscribe: <mailto:raindrops-unsubscribe@librelist.com>
Precedence: list
Original-Sender: raindrops@librelist.org
Xref: news.gmane.org gmane.comp.lang.ruby.raindrops.general:62
Archived-At:
 <http://permalink.gmane.org/gmane.comp.lang.ruby.raindrops.general/62>
Received: from zedshaw.xen.prgmr.com ([64.71.167.205]) by plane.gmane.org
 with esmtp (Exim 4.69) (envelope-from <raindrops@librelist.org>) id
 1SSbKR-0004yX-Tq for gclrrg-raindrops@m.gmane.org; Thu, 10 May 2012 23:55:20
 +0200
Received: from zedshaw.xen.prgmr.com (localhost [IPv6:::1]) by
 zedshaw.xen.prgmr.com (Postfix) with ESMTP id 4A41421DAF2 for
 <gclrrg-raindrops@m.gmane.org>; Thu, 10 May 2012 22:02:42 +0000 (UTC)

I've just pushed this out to master on git://bogomips.org/raindrops

The original check for "i386" arch was causing builds on SmartOS
to fail.

Also available as a prerelease gem (0.8.0.5.g71f8):

  gem install --pre raindrops

>>From 71f80afdbcb45245a01ee2c278ebda692587e92a Mon Sep 17 00:00:00 2001
From: Eric Wong <normalperson@yhbt.net>
Date: Thu, 10 May 2012 14:49:39 -0700
Subject: [PATCH] extconf: better check for GCC atomic builtins

Attempting to test for CMPXCHG on x86 should allow this check to
fail on i386 systems.  We also won't need try_run as a result,
enabling cross-compilation.  The configure.in check in Ruby
1.9.3 does something similar and that's far more widely used
than raindrops is.
---
 ext/raindrops/extconf.rb |   15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/ext/raindrops/extconf.rb b/ext/raindrops/extconf.rb
index 9f5de95..447a90a 100644
--- a/ext/raindrops/extconf.rb
+++ b/ext/raindrops/extconf.rb
@@ -13,23 +13,20 @@ have_func('rb_thread_blocking_region')
 have_func('rb_thread_io_blocking_region')
 
 checking_for "GCC 4+ atomic builtins" do
+  # we test CMPXCHG anyways even though we don't need it to filter out
+  # ancient i386-only targets without CMPXCHG
   src = <<SRC
 int main(int argc, char * const argv[]) {
-        volatile unsigned long i = 0;
+        unsigned long i = 0;
+        __sync_lock_test_and_set(&i, 0);
+        __sync_lock_test_and_set(&i, 1);
         __sync_add_and_fetch(&i, argc);
         __sync_sub_and_fetch(&i, argc);
         return 0;
 }
 SRC
 
-  if try_run(src)
-    # some systems target GCC for i386 and don't get the atomic builtins
-    # when building shared objects
-    arch = `#{CONFIG['CC']} -dumpmachine`.split(/-/)[0]
-    if arch == "i386" && $CFLAGS !~ /\b-march=/
-      $CFLAGS += " -march=i486 "
-    end
-
+  if try_link(src)
     $defs.push(format("-DHAVE_GCC_ATOMIC_BUILTINS"))
     true
   else
-- 
Eric Wong