From: Eric Wong <email@example.com> To: firstname.lastname@example.org Subject: Re: Re: [PATCH] Remove Scope IDs from IPv6 addresses. Date: Tue, 10 Sep 2013 20:17:06 +0000 Message-ID: <20130910201706.GA6250@dcvr.yhbt.net> (raw) In-Reply-To: <CAAB-KcnSoHwcpMPBOdvHascKUsXMngyOhWmeXRJE=ZzP-Xn6email@example.com> Hleb Valoshka <firstname.lastname@example.org> wrote: > On 9/10/13, Eric Wong <email@example.com> wrote: > >> + newaddr = strdup(addr); > >> + if (newaddr == NULL) > >> + perror("strdup"); > > > > We'll segfault on strchr below if we perrored above. If we continue > > using strdup, I would just use ruby_strdup() (works on both MRI/rbx). > > I haven't use C for a long time, so I thought that strchr checks its args. > > > But I'd rather avoid *strdup entirely. This is unlikely to > > remove, right? > > Frankly speaking I dislike functions similar to strdup(), because > using them you should remember to call free(), sometimes in many > places (or to use goto). But I'm unfamiliar with internal ruby api, so > it was the only variant for me. I try to avoid strdup, too. I can help you with Ruby C API :) The advantage of creating Ruby strings right away is it maintains length, so one can use mem* functions instead of str* functions (always faster and more explicit, often safer, and never less safe). > BTW, is anything bad with that variant: > char *newaddr = alloca(...); > remove_scope_id(oldaddr, newaddr); Probably OK in this case, but it would need a comment explaining to stack checkers the size is bounded and won't overflow. > > Perhaps something like this (totally untested, likely off-by-one errors) > > Ok, I'll test your code tomorrow. Thanks.
next prev parent reply index Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <firstname.lastname@example.org> [not found] ` <20130910183504.GA502@dcvr.yhbt.net> 2013-09-10 18:36 ` Eric Wong 2013-09-10 19:57 ` Hleb Valoshka 2013-09-10 20:17 ` Eric Wong [this message] 2013-09-11 16:12 ` Hleb Valoshka
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://yhbt.net/raindrops/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130910201706.GA6250@dcvr.yhbt.net \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
raindrops RubyGem user+dev discussion/patches/pulls/bugs/help Archives are clonable: git clone --mirror https://yhbt.net/raindrops-public git clone --mirror http://ou63pmih66umazou.onion/raindrops-public Example config snippet for mirrors Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.lang.ruby.raindrops nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.raindrops note: .onion URLs require Tor: https://www.torproject.org/ AGPL code for this site: git clone https://public-inbox.org/public-inbox.git