From: Eric Wong <e@80x24.org>
To: raindrops-public@bogomips.org
Subject: [PATCH] remove optimizations which made sense for older rubies
Date: Tue, 2 Feb 2016 22:40:40 +0000 [thread overview]
Message-ID: <20160202224040.30528-1-e@80x24.org> (raw)
Since Ruby 2.2, frozen string literals are implied for Hash#[]
lookups. Constant lookups have inline caching since Ruby 1.9
(from YARV).
Ruby 1.8.7 will continue to be supported, but the code will
favor performance features of newer Rubies.
---
lib/raindrops/aggregate/last_data_recv.rb | 6 +-----
lib/raindrops/middleware.rb | 3 +--
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/lib/raindrops/aggregate/last_data_recv.rb b/lib/raindrops/aggregate/last_data_recv.rb
index eca89a2..6919fbc 100644
--- a/lib/raindrops/aggregate/last_data_recv.rb
+++ b/lib/raindrops/aggregate/last_data_recv.rb
@@ -13,10 +13,6 @@
# - Kgio::TCPServer#kgio_accept
# - Kgio::TCPServer#kgio_tryaccept
module Raindrops::Aggregate::LastDataRecv
- # :stopdoc:
- TCP_Info = Raindrops::TCP_Info
- # :startdoc:
-
# The integer value of +last_data_recv+ is sent to this object.
# This is usually a duck type compatible with the \Aggregate class,
# but can be *anything* that accepts the *<<* method.
@@ -78,7 +74,7 @@ def accept_nonblock
# +last_data_recv+ to be accurate
def count!(io)
if io
- x = TCP_Info.new(io)
+ x = Raindrops::TCP_Info.new(io)
@raindrops_aggregate << x.last_data_recv
end
io
diff --git a/lib/raindrops/middleware.rb b/lib/raindrops/middleware.rb
index 7c647ec..bf16924 100644
--- a/lib/raindrops/middleware.rb
+++ b/lib/raindrops/middleware.rb
@@ -81,7 +81,6 @@ class Stats < Raindrops::Struct.new(:calling, :writing)
end
# :stopdoc:
- PATH_INFO = "PATH_INFO"
require "raindrops/middleware/proxy"
# :startdoc:
@@ -111,7 +110,7 @@ def initialize(app, opts = {})
# standard Rack endpoint
def call(env) # :nodoc:
- env[PATH_INFO] == @path and return stats_response
+ env['PATH_INFO'] == @path and return stats_response
begin
@stats.incr_calling
--
EW
reply other threads:[~2016-02-02 22:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/raindrops/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202224040.30528-1-e@80x24.org \
--to=e@80x24.org \
--cc=raindrops-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/raindrops.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).