From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.8 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, RP_MATCHES_RCVD,URIBL_BLOCKED shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: raindrops-public@bogomips.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 44E7320455; Tue, 23 Feb 2016 01:51:38 +0000 (UTC) Date: Tue, 23 Feb 2016 01:51:38 +0000 From: Eric Wong To: Hleb Valoshka <375gnu@gmail.com>, Antonio Terceiro Cc: raindrops-public@bogomips.org, Antonio Terceiro Subject: Re: [PATCH] test/test_linux.rb: use plain ASCII in tempfile name Message-ID: <20160223015138.GA6672@dcvr.yhbt.net> References: <1456163396-21079-1-git-send-email-terceiro@softwarelivre.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: Hleb Valoshka <375gnu@gmail.com> wrote: Hleb: please reply-to-all, we don't require subscription since moving off librelist. This also prevents the list server being a single-point-of-failure(-or-censorship). > On 2/22/16, Antonio Terceiro wrote: > > On Debian, this fixes the build against ruby2.3, which otherwise fails > > with errors like: > > > > RegexpError: /.../n has a non escaped non ASCII character in non ASCII-8BIT > > script > > - tmp = Tempfile.new("\xde\xad\xbe\xef") # valid path, really :) > > + tmp = Tempfile.new('raindrops') > > I suspect that such names were created intentionally, so your patch > may not be correct. Right; raindrops should work with any paths the FS may throw at it. I posted an alternate RFC patch for this problem a few weeks ago: http://bogomips.org/raindrops-public/20160202183136.21549-1-e@80x24.org/raw I'm tempted to apply the above as Ruby might continue with existing behavior. Antonio: thoughts?