From: Antonio Terceiro <terceiro@softwarelivre.org> To: Eric Wong <normalperson@yhbt.net> Cc: Hleb Valoshka <375gnu@gmail.com>, raindrops-public@bogomips.org Subject: Re: [PATCH] test/test_linux.rb: use plain ASCII in tempfile name Date: Tue, 23 Feb 2016 08:00:09 -0300 [thread overview] Message-ID: <20160223110009.GB31015@softwarelivre.org> (raw) In-Reply-To: <20160223015138.GA6672@dcvr.yhbt.net> [-- Attachment #1: Type: text/plain, Size: 1385 bytes --] On Tue, Feb 23, 2016 at 01:51:38AM +0000, Eric Wong wrote: > Hleb Valoshka <375gnu@gmail.com> wrote: > > Hleb: please reply-to-all, we don't require subscription > since moving off librelist. This also prevents the list server > being a single-point-of-failure(-or-censorship). > > > On 2/22/16, Antonio Terceiro <terceiro@softwarelivre.org> wrote: > > > On Debian, this fixes the build against ruby2.3, which otherwise fails > > > with errors like: > > > > > > RegexpError: /.../n has a non escaped non ASCII character in non ASCII-8BIT > > > script > > > - tmp = Tempfile.new("\xde\xad\xbe\xef") # valid path, really :) > > > + tmp = Tempfile.new('raindrops') > > > > I suspect that such names were created intentionally, so your patch > > may not be correct. > > Right; raindrops should work with any paths the FS may throw at it. I did realize it was on purpose, but didn't have the time to dig it the root cause and wen't with the easiest fix I could find. > I posted an alternate RFC patch for this problem a few weeks ago: > > http://bogomips.org/raindrops-public/20160202183136.21549-1-e@80x24.org/raw > > I'm tempted to apply the above as Ruby might continue with existing > behavior. > > Antonio: thoughts? Works for me as well. -- Antonio Terceiro <terceiro@softwarelivre.org> http://softwarelivre.org/terceiro [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 820 bytes --]
next prev parent reply other threads:[~2016-02-23 11:00 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-22 17:49 Antonio Terceiro 2016-02-22 18:28 ` Hleb Valoshka 2016-02-23 1:51 ` Eric Wong 2016-02-23 11:00 ` Antonio Terceiro [this message] 2016-02-29 12:47 ` Eric Wong 2016-03-01 12:01 ` Antonio Terceiro
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://yhbt.net/raindrops/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160223110009.GB31015@softwarelivre.org \ --to=terceiro@softwarelivre.org \ --cc=375gnu@gmail.com \ --cc=normalperson@yhbt.net \ --cc=raindrops-public@bogomips.org \ --subject='Re: [PATCH] test/test_linux.rb: use plain ASCII in tempfile name' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: ../../raindrops.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).