From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 4D0171F9F4; Mon, 22 Nov 2021 17:56:33 +0000 (UTC) Date: Mon, 22 Nov 2021 17:56:33 +0000 From: Eric Wong To: KJ Tsanaktsidis Cc: raindrops-public@yhbt.net Subject: Re: [PATCH] Allow Raindrops objects to be backed by a memfd file Message-ID: <20211122175633.GA23628@dcvr> References: <20211122010336.43463-1-ktsanaktsidis@zendesk.com> <20211122084200.GA10182@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: KJ Tsanaktsidis wrote: > On Mon, Nov 22, 2021 at 7:48 PM Eric Wong wrote: > > Anyways thanks again for bringing this up. Let us know if you > > want to tackle handling my suggestions or if you want to wait > > for me to do it. > > I think I committed the two cardinal sins of mailing list etiquette at > once - replied off list and in HTML /facepalm. Also, no need to quote excessively :) Anyways, thanks for correcting yourself. Fwiw, any attachment costs around 3x more memory for my spam filter, and decoding HTML is probably 10x or more in terms of CPU usage compared to plain-text. I'm also storing and indexing around 15 million emails across many projects while trying to get as many independently-run mirrors up as possible; so yes, these bytes matter :) > Copying my reply in here again.... sorry! > > -------------------------------------------------------------- > > Hi Eric, > > Thank you for the really detailed feedback on this patch! I haven’t really > written much in the way of Ruby C extensions before, so it’s really > valuable to me to get your thoughts. No problem. While I'm mostly retired from Ruby, it's still a useful break from my other projects for me to review code. > I’m definitely happy to send another version of this later this week. Yeah, no rush; holidays and all.