raindrops RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Dale Hamel <dale.hamel@shopify.com>
Cc: raindrops-public@yhbt.net
Subject: Re: [PATCH] Fix queue stats for sockets with SO_REUSEPORT
Date: Sat, 25 Feb 2023 00:36:10 +0000	[thread overview]
Message-ID: <20230225003610.M538677@dcvr> (raw)
In-Reply-To: <CA+G7BaHaftciDqK4gzE2ANVffB-DMdPaBAwCwCn1cB1i38jGCQ@mail.gmail.com>

Dale Hamel <dale.hamel@shopify.com> wrote:
> > I'm honestly shocked that these features get used;
> > I never convinced the org I worked for to use them :x
> So far we haven't actually found a production use case
> for SO_REUSEPORT with Unicorn. We thought we had some
> promising early results - but it turned out to be this
> instrumentation error in raindrops.

Oh, I meant the socket instrumentation part of raindrops.

I figured atomic counters were the only thing that ever got used.

Anyways I think SO_REUSEPORT was too risky due to the
possibility of connection drops, but then again I haven't used
more than 4 real cores.

> At least by fixing this, efforts in the future will have the correct
> metrics to base tests off of.


> > Anything else?  Could tag a release in a bit...
> No, that's it! My apologies for sending as two patches,
> I didn't notice the bug in my test until I had already
> submitted, naturally.

No worries.  In the future, you can also ask me to do a squash
in the diffstat area or signature area, or use [SQUASH] instead of
[PATCH] in the subject prefix.

> Thanks very much for the quick review!

np.  Easy for me as long as I never leave a terminal :>

      reply	other threads:[~2023-02-25  0:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24 18:35 [PATCH] Fix queue stats for sockets with SO_REUSEPORT Dale Hamel
2023-02-24 18:47 ` [PATCH] Fix off by one error in test Dale Hamel
2023-02-24 19:09 ` [PATCH] Fix queue stats for sockets with SO_REUSEPORT Eric Wong
2023-02-24 19:42   ` Dale Hamel
2023-02-25  0:36     ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/raindrops/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230225003610.M538677@dcvr \
    --to=e@80x24.org \
    --cc=dale.hamel@shopify.com \
    --cc=raindrops-public@yhbt.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).