Re: [PATCH] Fix queue stats for sockets with SO_REUSEPORT

[Eric Wong <e@80x24.org>]

Dale Hamel <dale.hamel@shopify.com> wrote:
> > I'm honestly shocked that these features get used;
> > I never convinced the org I worked for to use them :x
> 
> So far we haven't actually found a production use case
> for SO_REUSEPORT with Unicorn. We thought we had some
> promising early results - but it turned out to be this
> instrumentation error in raindrops.

Oh, I meant the socket instrumentation part of raindrops.

I figured atomic counters were the only thing that ever got used.

Anyways I think SO_REUSEPORT was too risky due to the
possibility of connection drops, but then again I haven't used
more than 4 real cores.

> At least by fixing this, efforts in the future will have the correct
> metrics to base tests off of.

Cool.

> > Anything else?  Could tag a release in a bit...
> 
> No, that's it! My apologies for sending as two patches,
> I didn't notice the bug in my test until I had already
> submitted, naturally.

No worries.  In the future, you can also ask me to do a squash
in the diffstat area or signature area, or use [SQUASH] instead of
[PATCH] in the subject prefix.

> Thanks very much for the quick review!

np.  Easy for me as long as I never leave a terminal :>