From: Eric Wong <email@example.com>
To: Samuel Williams <firstname.lastname@example.org>
Subject: Re: [PATCH] Prefer to use rb_io_descriptor in my_fileno
Date: Fri, 9 Jun 2023 10:16:50 +0000 [thread overview]
Message-ID: <20230609101650.M437462@dcvr> (raw)
Samuel Williams <email@example.com> wrote:
Where's the commit message body?
At minimum, non-trivial commits must have an explanation of why
a change is necessary. This is important to reviewers who don't
follow Ruby core development closely.
Even one sentence for the "why" is fine as long as it can be
meaningful to offline reviewers. References to online sources are
fine (full URLs, not #NNN); but it needs to be accompanied by a
summary for offline users. See `git log' for examples.
In the case of this patch; I would also like to know which Ruby
implementation(s) and version(s) it appears in; and evidence
backing up that it's a supported public API we can depend on
On a side note, describing "what" you're doing file-by-file
is totally uninteresting when it's obvious from reading
the patch. IOW, old ruby.git and GNU ChangeLog conventions
are a waste of time+effort for users with `git log -p'.
Please ensure HTML is off and keep raindrops-public Cc-ed in responses.
next prev parent reply other threads:[~2023-06-09 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 8:58 [PATCH] Prefer to use rb_io_descriptor in my_fileno Samuel Williams
2023-06-09 10:16 ` Eric Wong [this message]
[not found] <5679D720-AD66-4471-9061-625159E71514@oriontransfer.co.nz>
2023-06-09 11:01 ` Samuel Williams
2023-06-10 7:30 Jean Boussier
2023-06-11 21:39 ` Eric Wong
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://yhbt.net/raindrops/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).