From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 8A1CB1F542; Fri, 9 Jun 2023 10:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1686305810; bh=F4LT7sW+f0KWzYXeVLR2CJH5P+f8eauk/04fOtPKf0Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nagodCO4jANOjvJKzt1u4V3NCJpGpiXEeO+Bi/k111slU3wy96zU/152Rcp5lCKkH ZWyyz/uUTuQr4YSMpIv6ijv9IyUAI51UvUiLq3IFu8qmnRDI/OJWhj3NkgIo7kO7L/ fF7QJT4SQvsM4rdgeq/mPOX2x+h9Ym2hHRn1/UwU= Date: Fri, 9 Jun 2023 10:16:50 +0000 From: Eric Wong To: Samuel Williams Cc: raindrops-public@yhbt.net Subject: Re: [PATCH] Prefer to use rb_io_descriptor in my_fileno Message-ID: <20230609101650.M437462@dcvr> References: <20230609085806.37650-1-samuel.williams@oriontransfer.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230609085806.37650-1-samuel.williams@oriontransfer.co.nz> List-Id: Samuel Williams wrote: > --- Where's the commit message body? At minimum, non-trivial commits must have an explanation of why a change is necessary. This is important to reviewers who don't follow Ruby core development closely. Even one sentence for the "why" is fine as long as it can be meaningful to offline reviewers. References to online sources are fine (full URLs, not #NNN); but it needs to be accompanied by a summary for offline users. See `git log' for examples. In the case of this patch; I would also like to know which Ruby implementation(s) and version(s) it appears in; and evidence backing up that it's a supported public API we can depend on going forward. On a side note, describing "what" you're doing file-by-file is totally uninteresting when it's obvious from reading the patch. IOW, old ruby.git and GNU ChangeLog conventions are a waste of time+effort for users with `git log -p'. Please ensure HTML is off and keep raindrops-public Cc-ed in responses. Thanks.