raindrops RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <bofh@yhbt.net>
To: raindrops-public@yhbt.net
Subject: [PATCH 2/4] my_fileno: use rb_io_check_closed for Ruby <3.1
Date: Sun, 11 Jun 2023 21:33:26 +0000	[thread overview]
Message-ID: <20230611213328.379546-3-bofh@yhbt.net> (raw)
In-Reply-To: <20230611213328.379546-1-bofh@yhbt.net>

This is less code and hopefully smaller binaries.
`rb_io_check_closed' has been in Ruby since the pre-CVS of
decades ago, and it doesn't matter if it's removed or not
in the future since Ruby 3.1+ doesn't see this code path
and calls `rb_io_descriptor' directly.
 ext/raindrops/my_fileno.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ext/raindrops/my_fileno.h b/ext/raindrops/my_fileno.h
index 646f31b..3a0100f 100644
--- a/ext/raindrops/my_fileno.h
+++ b/ext/raindrops/my_fileno.h
@@ -9,9 +9,8 @@ static int my_fileno(VALUE io)
 	rb_io_t *fptr;
 	GetOpenFile(io, fptr);
+	rb_io_check_closed(fptr);
-	if (fptr->fd < 0)
-		rb_raise(rb_eIOError, "closed stream");
 	return fptr->fd;
 #endif /* Ruby <3.1 !HAVE_RB_IO_DESCRIPTOR */

  parent reply	other threads:[~2023-06-11 21:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-11 21:33 [PATCH 0/4] minor modernizations and cleanups Eric Wong
2023-06-11 21:33 ` [PATCH 1/4] avoid unnecessary #to_io calls Eric Wong
2023-06-11 21:33 ` Eric Wong [this message]
2023-06-11 21:33 ` [PATCH 3/4] linux_inet_diag: get rid of alloca usage Eric Wong
2023-06-11 21:33 ` [PATCH 4/4] test_linux_reuseport_tcp_listen_stats: skip w/o unicorn Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/raindrops/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230611213328.379546-3-bofh@yhbt.net \
    --to=bofh@yhbt.net \
    --cc=raindrops-public@yhbt.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).