raindrops RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <bofh@yhbt.net>
To: Jean Boussier <jean.boussier@gmail.com>
Cc: samuel.williams@oriontransfer.co.nz, raindrops-public@yhbt.net,
Subject: Re: [PATCH] Prefer to use rb_io_descriptor in my_fileno
Date: Sun, 11 Jun 2023 21:39:30 +0000	[thread overview]
Message-ID: <20230611213930.M342144@dcvr> (raw)
In-Reply-To: <3DC9CAC8-5708-4001-B4F1-899D46DA9AC1@gmail.com>

Jean Boussier <jean.boussier@gmail.com> wrote:
> >  the "why"
> I think the missing piece here is that this change is necessary for compatibility with the current ruby master:
> https://bugs.ruby-lang.org/issues/19057#note-17

Thanks, that's an important note omitted from both original patches.

I've pushed out Samuel's patch as commit
b3212417cc3e7cc44aa9e1ffe89b0d62ef3fdab5 to raindrops.git
with your comment

> kgio seem to have the same code and fail in the same way.

+Cc kgio-public@yhbt.net

I'll take documented patches for kgio, otherwise I'll try to deal with it
before Ruby 3.3 (or when Debian stable ships Ruby 3.3 :P).

I've also posted some raindrops cleanups and modernizations
which should reduce stack frames and binary size for 3.1+
(untested since I don't have space/time for multiple Ruby
installs atm):

  reply	other threads:[~2023-06-11 21:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-10  7:30 [PATCH] Prefer to use rb_io_descriptor in my_fileno Jean Boussier
2023-06-11 21:39 ` Eric Wong [this message]
     [not found] <5679D720-AD66-4471-9061-625159E71514@oriontransfer.co.nz>
2023-06-09 11:01 ` Samuel Williams
  -- strict thread matches above, loose matches on Subject: below --
2023-06-09  8:58 Samuel Williams
2023-06-09 10:16 ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/raindrops/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230611213930.M342144@dcvr \
    --to=bofh@yhbt.net \
    --cc=jean.boussier@gmail.com \
    --cc=kgio-public@yhbt.net \
    --cc=raindrops-public@yhbt.net \
    --cc=samuel.williams@oriontransfer.co.nz \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).