From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bofh@yhbt.net>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
	T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no
	version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 74A9C1F542;
	Sun, 11 Jun 2023 21:39:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yhbt.net;
	s=selector1; t=1686519570;
	bh=Fd4QFektlHEkrRDRHQ13mZjKdpwmaE7UO654w5fkIAs=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=mf8Ser2GI2oMM+JRzcyryBjTrUaa329F2bOD1mZRsVHYVL0wJyTJSM2z6zu3tpNL3
	 vSdUdiKp0zOnuC2/gwYrLDTp0LNcr916+AFal5O1uHKB9J9JeT+9i0tgdTu29cxYKC
	 vOCK3EAqoTxwQMiqU4SCJlil/OSqnL8VSvSLrfiY=
Date: Sun, 11 Jun 2023 21:39:30 +0000
From: Eric Wong <bofh@yhbt.net>
To: Jean Boussier <jean.boussier@gmail.com>
Cc: samuel.williams@oriontransfer.co.nz, raindrops-public@yhbt.net,
	kgio-public@yhbt.net
Subject: Re: [PATCH] Prefer to use rb_io_descriptor in my_fileno
Message-ID: <20230611213930.M342144@dcvr>
References: <3DC9CAC8-5708-4001-B4F1-899D46DA9AC1@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <3DC9CAC8-5708-4001-B4F1-899D46DA9AC1@gmail.com>
List-Id: <raindrops-public.yhbt.net>

Jean Boussier <jean.boussier@gmail.com> wrote:
> >  the "why"
> 
> I think the missing piece here is that this change is necessary for compatibility with the current ruby master:
> 
> https://bugs.ruby-lang.org/issues/19057#note-17

Thanks, that's an important note omitted from both original patches.

I've pushed out Samuel's patch as commit
b3212417cc3e7cc44aa9e1ffe89b0d62ef3fdab5 to raindrops.git
with your comment

> kgio seem to have the same code and fail in the same way.

+Cc kgio-public@yhbt.net

I'll take documented patches for kgio, otherwise I'll try to deal with it
before Ruby 3.3 (or when Debian stable ships Ruby 3.3 :P).


I've also posted some raindrops cleanups and modernizations
which should reduce stack frames and binary size for 3.1+
(untested since I don't have space/time for multiple Ruby
installs atm):
https://yhbt.net/raindrops-public/20230611213328.379546-1-bofh@yhbt.net/