* [PATCH] Fix off by one error in test
@ 2023-02-24 18:47 7% ` Dale Hamel
2023-02-24 19:09 4% ` [PATCH] Fix queue stats for sockets with SO_REUSEPORT Eric Wong
1 sibling, 0 replies; 3+ results
From: Dale Hamel @ 2023-02-24 18:47 UTC (permalink / raw)
To: dale.hamel; +Cc: raindrops-public
It doesn't affect the test outcome, but it is not the intended behaviour of
the test.
We listen once to find out what port to use, then should bind with SO_REUSEPORT
N-1 times, but we are doing it N times, so we have one extra listener.
---
test/test_linux_reuseport_tcp_listen_stats.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test_linux_reuseport_tcp_listen_stats.rb b/test/test_linux_reuseport_tcp_listen_stats.rb
index c977c43..73995ea 100644
--- a/test/test_linux_reuseport_tcp_listen_stats.rb
+++ b/test/test_linux_reuseport_tcp_listen_stats.rb
@@ -36,7 +36,7 @@ def test_reuseport_queue_stats
listeners = 10
_, port = new_socket_server(reuseport: true)
addr = "#{TEST_ADDR}:#{port}"
- listeners.times do
+ (listeners - 1).times do
new_socket_server(reuseport: true, port: port)
end
--
2.39.2
^ permalink raw reply related [relevance 7%]
* Re: [PATCH] Fix queue stats for sockets with SO_REUSEPORT
2023-02-24 18:47 7% ` [PATCH] Fix off by one error in test Dale Hamel
@ 2023-02-24 19:09 4% ` Eric Wong
1 sibling, 0 replies; 3+ results
From: Eric Wong @ 2023-02-24 19:09 UTC (permalink / raw)
To: Dale Hamel; +Cc: raindrops-public
Thanks, pushed to raindrops.git:
10d5fb25b631 Fix off by one error in test
a5902f243cd2 Fix queue stats for sockets with SO_REUSEPORT
I'm honestly shocked that these features get used;
I never convinced the org I worked for to use them :x
Anything else? Could tag a release in a bit...
^ permalink raw reply [relevance 4%]
* [ANN] raindrops 0.20.1 - real-time stats for preforking Rack servers
@ 2023-02-25 0:23 3% Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2023-02-25 0:23 UTC (permalink / raw)
To: ruby-talk, raindrops-public; +Cc: Dale Hamel
raindrops is a real-time stats toolkit to show statistics for Rack HTTP
servers. It is designed for preforking servers such as unicorn, but
should support any Rack HTTP server on platforms supporting POSIX shared
memory. It may also be used as a generic scoreboard for sharing atomic
counters across multiple processes.
* https://yhbt.net/raindrops/
* public mail box (no subscribers, no HTML mail): raindrops-public@yhbt.net
* mail archives: https://yhbt.net/raindrops-public/
http://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/raindrops-public
imaps://yhbt.net/inbox.comp.lang.ruby.raindrops.0
nntp://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.lang.ruby.raindrops
imap://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.lang.ruby.raindrops.0
(.onion URLs require Tor)
* git clone https://yhbt.net/raindrops.git
* torsocks git clone http://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/raindrops.git
* https://yhbt.net/raindrops/NEWS.atom.xml
Changes:
raindrops 0.20.1
Stats for SO_REUSEPORT sockets are now handled properly.
Thanks to Dale Hamel for the patches.
Dale Hamel (2):
Fix queue stats for sockets with SO_REUSEPORT
Fix off by one error in test
--
-_-
^ permalink raw reply [relevance 3%]
Results 1-3 of 3 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-02-24 18:35 [PATCH] Fix queue stats for sockets with SO_REUSEPORT Dale Hamel
2023-02-24 18:47 7% ` [PATCH] Fix off by one error in test Dale Hamel
2023-02-24 19:09 4% ` [PATCH] Fix queue stats for sockets with SO_REUSEPORT Eric Wong
2023-02-25 0:23 3% [ANN] raindrops 0.20.1 - real-time stats for preforking Rack servers Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/raindrops.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).