raindrops RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [ANN] raindrops 0.15.0 - real-time stats for preforking Rack servers
@ 2015-07-22  0:34  6% Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2015-07-22  0:34 UTC (permalink / raw)
  To: ruby-talk, raindrops-public

Raindrops is a real-time stats toolkit to show statistics for Rack HTTP
servers.  It is designed for preforking servers such as Rainbows! and
Unicorn, but should support any Rack HTTP server under Ruby 2.0, 1.9,
1.8 and Rubinius on platforms supporting POSIX shared memory.  It may
also be used as a generic scoreboard for sharing atomic counters across
multiple processes.

* http://raindrops.bogomips.org/
* No subscription necessary, no HTML mail:
  raindrops-public@bogomips.org
* git clone git://bogomips.org/raindrops.git
* http://raindrops.bogomips.org/NEWS.atom.xml
* http://raindrops-demo.bogomips.org/

Changes: non-glibc compat fix on Linux

Thanks to Doug Forster for sending us the report.
No other fixes

* check for the existence of linux/tcp.h

-- 
EW

^ permalink raw reply	[relevance 6%]

* Re: raindrops fails to install with ruby 2.2.2
  @ 2015-07-14 20:18  7% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2015-07-14 20:18 UTC (permalink / raw)
  To: Doug Forster; +Cc: raindrops-public

Please don't send HTML portions in email, it is bloated and spammy
and incompatible with lists we may Cc:

...And I expect musl users to care about bloat like that :>

Doug Forster <doug.forster@gmail.com> wrote:
> Problem seems to be the removal of rb_thread_blocking_region in ruby.

Actually, that's a red herring, raindrops 0.13.0 onwards accounts
for that.

> System Info:
> ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux-musl]
> alpine linux


> make "DESTDIR="
> compiling linux_tcp_info.c
> linux_tcp_info.c:5:23: fatal error: linux/tcp.h: No such file or directory
>  #include <linux/tcp.h>
>                        ^
> compilation terminated.
> Makefile:237: recipe for target 'linux_tcp_info.o' failed
> make: *** [linux_tcp_info.o] Error 1
> 
> make failed, exit code 2

This is the problem, raindrops blindly assumed Linux machines all have
linux/tcp.h header.  I've added a check for that.

I'll push out the patch below and release 0.14.1 final soon.

I've pushed out raindrops 0.14.0.1.g8177 with the patch below.

You should be able to install it using:

	gem install --pre raindrops -v 0.14.0.1.g8177

If possible, can you test and make sure there's no other issues?
Thanks.

------------------------------ 8< ----------------------------
From: Eric Wong <e@80x24.org>
Date: Tue, 14 Jul 2015 20:08:49 +0000
Subject: [PATCH] check for the existence of linux/tcp.h

The linux/tcp.h header may not exist on alternative libc
implementations such as musl.

Noticed-by: Doug Forster <doug.forster@gmail.com>
---
 ext/raindrops/extconf.rb       | 1 +
 ext/raindrops/linux_tcp_info.c | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/ext/raindrops/extconf.rb b/ext/raindrops/extconf.rb
index f012808..74ed8f9 100644
--- a/ext/raindrops/extconf.rb
+++ b/ext/raindrops/extconf.rb
@@ -6,6 +6,7 @@
 
 $CPPFLAGS += " -D_GNU_SOURCE "
 have_func('mremap', 'sys/mman.h')
+have_header('linux/tcp.h')
 
 $CPPFLAGS += " -D_BSD_SOURCE "
 have_func("getpagesize", "unistd.h")
diff --git a/ext/raindrops/linux_tcp_info.c b/ext/raindrops/linux_tcp_info.c
index dcdb153..5e25d4d 100644
--- a/ext/raindrops/linux_tcp_info.c
+++ b/ext/raindrops/linux_tcp_info.c
@@ -1,4 +1,4 @@
-#ifdef __linux__
+#if defined(__linux__) && defined(HAVE_LINUX_TCP_H)
 #include <ruby.h>
 #include <sys/socket.h>
 #include <netinet/in.h>
@@ -170,4 +170,4 @@ void Init_raindrops_linux_tcp_info(void)
 	TCPI_DEFINE_METHOD(total_retrans);
 }
 #endif /* TCP_INFO */
-#endif /* __linux__ */
+#endif /* defined(__linux__) && defined(HAVE_LINUX_TCP_H) */
-- 
EW

^ permalink raw reply related	[relevance 7%]

Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2015-07-09 21:47     raindrops fails to install with ruby 2.2.2 Doug Forster
2015-07-14 20:18  7% ` Eric Wong
2015-07-22  0:34  6% [ANN] raindrops 0.15.0 - real-time stats for preforking Rack servers Eric Wong

Code repositories for project(s) associated with this public inbox

	https://yhbt.net/raindrops.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).